Skip to content

fix(tests): split test_benchmark_matrix.py to clear the 500-line gate#213

Merged
wesleyscholl merged 1 commit into
mainfrom
fix/konjo-gate-file-size
Jul 6, 2026
Merged

fix(tests): split test_benchmark_matrix.py to clear the 500-line gate#213
wesleyscholl merged 1 commit into
mainfrom
fix/konjo-gate-file-size

Conversation

@wesleyscholl

Copy link
Copy Markdown
Collaborator

Summary

  • main's Konjo Gate (G4 · Complexity + Size + DRY, and the aggregate Konjo Gate — All Walls Clear) has been failing since PR bench: cold/unique 0%-reuse head-to-head — squish beats ollama on TTFT, decode, and E2E #211 merged, which grew tests/test_benchmark_matrix.py from 499 to 543 lines — over the 500-line new-violation limit and not in .konjo/oversized-allowlist.txt.
  • Per project convention ("split them to remove, don't grow the list"), split the file along its own existing # ── section ── comment boundaries rather than allowlisting it:
    • tests/test_benchmark_matrix.py (288 lines): corpus, stats_ext, cache_probe
    • tests/test_benchmark_matrix_reporting.py (258 lines, new): memory, thermal, matrix_spec, host, cell pure helpers, report
  • No behavior change — same 64 tests, same assertions, just regrouped. Verified passing (pytest -v, 64 passed) and clean under ruff check / ruff format --check.

Note: this PR does not touch the complexity-gate's 146 flagged functions (radon cc -n C) — that step has continue-on-error: true in the workflow, so it's cosmetic/non-blocking, not what's actually failing CI. Fixing that debt is a much larger, unrelated undertaking across ~20 files and is out of scope here.

Also found, not addressed in this PR: the scheduled Model Compression Pipeline workflow has been failing daily since at least 2026-07-02 — it calls dev/scripts/model_pipeline.py, which was intentionally deleted in a "scrub internal artifacts and private paths for public repo" commit. Fixing that requires a judgment call (retire the dead workflow vs. restore internal tooling to the public repo) that needs a maintainer decision, not a mechanical fix.

Test plan

  • pytest tests/test_benchmark_matrix.py tests/test_benchmark_matrix_reporting.py -v — 64 passed
  • ruff check / ruff format --check — clean
  • Both files confirmed under 500 lines (288, 258)
  • Reviewer: confirm CI goes green on this branch

🤖 Generated with Claude Code

PR #211 grew tests/test_benchmark_matrix.py from 499 to 543 lines, tripping
the Konjo Gate file-size check (blocking on main since). Split along the
file's existing section boundaries: corpus/stats_ext/cache_probe stay in
test_benchmark_matrix.py (288 lines); memory/thermal/matrix_spec/host/cell/
report move to test_benchmark_matrix_reporting.py (258 lines). No behavior
change — same 64 tests, same assertions, verified passing in both files.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@wesleyscholl wesleyscholl merged commit 1678282 into main Jul 6, 2026
29 checks passed
@wesleyscholl wesleyscholl deleted the fix/konjo-gate-file-size branch July 6, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant