Open
Conversation
Pasha0666
reviewed
Dec 14, 2024
Comment on lines
+10
to
+12
| [SetCulture("")] | ||
| public class PrintingConfigTests | ||
| { |
There was a problem hiding this comment.
Не хватает тестов где свойство в поле какой-то класс
ObjectPrinting/ObjectPrinter.cs
Outdated
Comment on lines
+47
to
+50
| if (path != null && path.Contains(propertyValue.Value)) | ||
| { | ||
| throw new InvalidOperationException("Unable to print object with cyclic reference."); | ||
| } |
There was a problem hiding this comment.
Корректная обработка циклических ссылок между объектами. Для меня корректная обработка не должна приводить к ошибкам
Comment on lines
+8
to
10
|
|
||
| public class ObjectPrinter | ||
| { |
There was a problem hiding this comment.
на мой взгляд класс достаточно тяжело читается, классическая рекурсия тут бы выйграла для чтения
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Pasha0666