Skip to content

Алешев Руслан #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artBETEP wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Алешев Руслан #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26414f8
Testing homework
Nov 26, 2023
15c8a0e
Fixes
Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 43 additions & 18 deletions cs/HomeExercises/NumberValidatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,57 @@
using System;
using System.Runtime.InteropServices.ComTypes;
using System.Text.RegularExpressions;
using FluentAssertions;
using Microsoft.VisualStudio.TestPlatform.Common.Interfaces;
using Microsoft.VisualStudio.TestPlatform.CommunicationUtilities;
using NUnit.Framework;

namespace HomeExercises
{
public class NumberValidatorTests
{
[Test]
public void Test()
[TestCase(-1, 2, TestName = "Throw Exception on negative Precision")]
[TestCase(2, -1, TestName = "Throw Exception on negative Scale ")]
[TestCase(2, 3, TestName = "Throw Exception if Scale is greater than Precision ")]
[TestCase(1, 1, TestName = "Throw Exception if Scale is equal Precision ")]
[TestCase(0, 1, TestName = "Throw Exception on zero Precision ")]
public void NumberValidator_IncorrectValues_ThrowException(int precision, int scale)
{
Assert.Throws<ArgumentException>(() => new NumberValidator(-1, 2, true));
Assert.DoesNotThrow(() => new NumberValidator(1, 0, true));
Assert.Throws<ArgumentException>(() => new NumberValidator(-1, 2, false));
Assert.DoesNotThrow(() => new NumberValidator(1, 0, true));
Action a = () => new NumberValidator(precision, scale);

Assert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0.0"));
Assert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0"));
Assert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0.0"));
Assert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("00.00"));
Assert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("-0.00"));
Assert.IsTrue(new NumberValidator(17, 2, true).IsValidNumber("0.0"));
Assert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("+0.00"));
Assert.IsTrue(new NumberValidator(4, 2, true).IsValidNumber("+1.23"));
Assert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("+1.23"));
Assert.IsFalse(new NumberValidator(17, 2, true).IsValidNumber("0.000"));
Assert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("-1.23"));
Assert.IsFalse(new NumberValidator(3, 2, true).IsValidNumber("a.sd"));
a.Should().Throw<ArgumentException>();
}

[TestCase(1, 0, TestName = "Don't throw Exception on correct values")]
public void NumberValidator_CorrectValue_NotThrowException(int precision, int scale)
{
Action a = () => new NumberValidator(precision, scale);

a.Should().NotThrow<ArgumentException>();
}

[TestCase(17, 2, true, "0.0", TestName = "Return True on correct values")]
[TestCase(5, 2, true, "+12.34", TestName = "Positive float wit sign")]
[TestCase(5, 2, false, "-12.34", TestName = "Negative float wit sign")]
[TestCase(5, 0, true, "12345", TestName = "Integer")]
[TestCase(5, 2, true, "123,45", TestName = "Comma separated float")]
public void NumberValidator_CorrectValue_ShouldReturnTrue(int precision, int scale, bool onlyPositive,
string number)
{
new NumberValidator(precision, scale, onlyPositive).IsValidNumber(number).Should().Be(true);
}

[TestCase(3, 2, "a.sd", TestName = "Return False on incorrect number")]
[TestCase(3, 2, "", TestName = "Return False on empty string")]
[TestCase(3, 2, null, TestName = "Return False on null string")]
[TestCase(3, 2, "-1.23", TestName = "Return False on negative number if only positive allowed")]
[TestCase(4, 2, "1.111", TestName = "Return False if fraction is longer than Scale")]
[TestCase(4, 2, "111.11", TestName = "Return False if number length is greater than Precision")]
[TestCase(3, 2, "+1.23", TestName = "Return False if number length with sign is greater than Precision")]

public void NumberValidator_IncorrectValue_ShouldReturnFalse(int precision, int scale, string number)
{
new NumberValidator(precision, scale, true).IsValidNumber(number).Should().Be(false);
}
}

Expand Down
18 changes: 10 additions & 8 deletions cs/HomeExercises/ObjectComparison.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ public void CheckCurrentTsar()
new Person("Vasili III of Russia", 28, 170, 60, null));

// Перепишите код на использование Fluent Assertions.
Assert.AreEqual(actualTsar.Name, expectedTsar.Name);
Assert.AreEqual(actualTsar.Age, expectedTsar.Age);
Assert.AreEqual(actualTsar.Height, expectedTsar.Height);
Assert.AreEqual(actualTsar.Weight, expectedTsar.Weight);

Assert.AreEqual(expectedTsar.Parent!.Name, actualTsar.Parent!.Name);
Assert.AreEqual(expectedTsar.Parent.Age, actualTsar.Parent.Age);
Assert.AreEqual(expectedTsar.Parent.Height, actualTsar.Parent.Height);
Assert.AreEqual(expectedTsar.Parent.Parent, actualTsar.Parent.Parent);
// Cравниваем все свойства, кроме исключенных
actualTsar.Should().BeEquivalentTo(expectedTsar,
options => options.Excluding(x => x.Id).Excluding(x => x.Parent!.Id));

// Тесты описываются более естественным языком
// Сообщения об ошибках более информативны
// При добавлении новых полей для сравнения не нужно изменять тест

}

[Test]
Expand All @@ -36,6 +36,8 @@ public void CheckCurrentTsar_WithCustomEquality()
new Person("Vasili III of Russia", 28, 170, 60, null));

// Какие недостатки у такого подхода?
// При добавлении свойств нужно изменять метод AreEquals
// Неинформативное сообщение об ошибке - не понятно, в чем именно различаются объекты
Assert.True(AreEqual(actualTsar, expectedTsar));
}

Expand Down