🐛 Added back the reset of the repository before we send the response back #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This was causing bugs on the front end, where the files being read from disk, were not the reset versions, and therefore the patches were failing. * The internals of the reset, should still allow for multiple calls, this should not hurt anything and we still get the benifit of resetting on exception. Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
shawn-hurley
approved these changes
Feb 19, 2025
fabianvf
approved these changes
Feb 19, 2025
|
Will merge once green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #668