📖 Added a walkthrough of how to create a custom rule #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwmatthews
reviewed
Feb 20, 2025
docs/custom_ruleset.md
Outdated
| > The Maven artifact io.fabric8:kubernetes-model has been removed from the project and is no longer published. | ||
| > This artifact was just an aggregator of some of the Kubernetes model artifacts and had no specific purpose. It is no longer published, the io.fabric8:kubernetes-client-api or io.fabric8:kubernetes-openshift-uberjar artifacts should be used instead. | ||
|
|
||
| So for this, we will need to make sure that if the dependency `io.fabric8:kubernetes-model` is not used. |
There was a problem hiding this comment.
Worth a 2nd read of this sentence, maybe a typo, maybe wanted to remove the word "if"
There was a problem hiding this comment.
updated let me know if the new wording makes more sense.
jwmatthews
approved these changes
Feb 20, 2025
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
docs/add-creating-custom-rule
branch
from
1d4c565 to
a766b25
Compare
JonahSussman
requested changes
Feb 20, 2025
JonahSussman
changed the title
JonahSussman
changed the title
JonahSussman
changed the title
Co-authored-by: Jonah Sussman <[email protected]> Signed-off-by: Shawn Hurley <[email protected]>
Co-authored-by: Jonah Sussman <[email protected]> Signed-off-by: Shawn Hurley <[email protected]>
Co-authored-by: Jonah Sussman <[email protected]> Signed-off-by: Shawn Hurley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.