Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update application analysis CI tests #286

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

aufi
Copy link
Member

@aufi aufi commented Jul 18, 2024

Updating structure of test-data and adding kantra anlyze tests also for java binary and java with maven settings file.

Related to #233

aufi added 8 commits July 18, 2024 11:25
Updating structure of test-data and adding kantra anlyze tests also for
java binary and java with maven settings file.

Related to konveyor#233

Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
@aufi aufi changed the title Update application analysis CI tests 🌱 Update application analysis CI tests Jul 18, 2024
@aufi aufi closed this Aug 5, 2024
@aufi aufi reopened this Aug 5, 2024
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
@aufi
Copy link
Member Author

aufi commented Aug 20, 2024

Including also test for https://github.com/konveyor-ecosystem/coolstore @ main branch, quarkus and futher updates will follow.

@aufi aufi requested a review from eemcmullan August 21, 2024 06:12
Signed-off-by: Marek Aufart <[email protected]>
Copy link
Contributor

@jmle jmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look good, but the result makes me think that there's something wrong with kantra and the tackle-testapp-public app

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should name this directory tackle-testapp-public so that it's easier to find?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there seems to be something wrong with kantra here, because we should be getting one issue related to the local-storage-00001 rule that we're not getting in these results. @rromannissen FYI

<server>
<id>tackle-testapp</id>
<username>konveyor-read-only-bot</username>
<password>GITHUB_TOKEN</password>
Copy link
Contributor

@jmle jmle Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At what point do we substitute this token? Is it necessary or this is the actual token?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, for source analysis without dependencies, the settings.xml doesn't matter. For full-analysis it need to be replaced, will update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants