Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improve Responsiveness of Action Cells in Table Component on smaller screens #2145

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EstyBiton
Copy link

@EstyBiton EstyBiton commented Oct 29, 2024

Resolve stacking issue for action cells on smaller screens,in application inventory table and in controls table
Screenshot of the result:
Screenshot from 2024-10-29 13-40-07
Screenshot from 2024-10-29 13-40-20

@EstyBiton EstyBiton changed the title ✨Improve Responsiveness of Action Cells in Table Component on smaller screens ✨ Improve Responsiveness of Action Cells in Table Component on smaller screens Oct 29, 2024
@EstyBiton EstyBiton force-pushed the isActionCell-stacking-on-small-screens branch from a955912 to 03eff5d Compare October 29, 2024 12:07
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.98%. Comparing base (b654645) to head (bea9194).
Report is 241 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
+ Coverage   39.20%   41.98%   +2.78%     
==========================================
  Files         146      175      +29     
  Lines        4857     5630     +773     
  Branches     1164     1394     +230     
==========================================
+ Hits         1904     2364     +460     
- Misses       2939     3250     +311     
- Partials       14       16       +2     
Flag Coverage Δ
client 41.98% <ø> (+2.78%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the change keeps the action buttons aligned properly when the screen gets narrow.

Is there an issue/ticket for this change? Please reference in the PR description.

Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! However I see some risk of breaking the e2e tests as we change the id of the action cell.
@mguetta1 we cannot run currently e2e in CI due to broken OLM installation scripts. Can you run the CI in tackle-ui-test repo on it?

btw @sjd78 the ids should be unique within the page - this looks like candidate for refactoring. What do you think?

@mguetta1
Copy link
Collaborator

@sjd78 It fixes #2111

@rszwajko The OLM installation issue should be fixed by now, I gave it another try

@rszwajko
Copy link
Collaborator

@mguetta1
I see the e2e are up and running and they do fail on this PR so we need a fix in the test repo. Otherwise I'm OK with the change.

@mguetta1
Copy link
Collaborator

@mguetta1 I see the e2e are up and running and they do fail on this PR so we need a fix in the test repo. Otherwise I'm OK with the change.

Sure, we will take care of that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants