-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Improve Responsiveness of Action Cells in Table Component on smaller screens #2145
base: main
Are you sure you want to change the base?
✨ Improve Responsiveness of Action Cells in Table Component on smaller screens #2145
Conversation
Signed-off-by: EstyBiton <[email protected]>
a955912
to
03eff5d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2145 +/- ##
==========================================
+ Coverage 39.20% 41.98% +2.78%
==========================================
Files 146 175 +29
Lines 4857 5630 +773
Branches 1164 1394 +230
==========================================
+ Hits 1904 2364 +460
- Misses 2939 3250 +311
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the change keeps the action buttons aligned properly when the screen gets narrow.
Is there an issue/ticket for this change? Please reference in the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! However I see some risk of breaking the e2e tests as we change the id of the action cell.
@mguetta1 we cannot run currently e2e in CI due to broken OLM installation scripts. Can you run the CI in tackle-ui-test repo on it?
btw @sjd78 the ids should be unique within the page - this looks like candidate for refactoring. What do you think?
@mguetta1 |
Sure, we will take care of that. Thanks! |
Resolve stacking issue for action cells on smaller screens,in application inventory table and in controls table
Screenshot of the result: