fix: inject version for path dependencies in workspace virtual manifests#238
Open
tomkarw wants to merge 1 commit into
Open
fix: inject version for path dependencies in workspace virtual manifests#238tomkarw wants to merge 1 commit into
tomkarw wants to merge 1 commit into
Conversation
NiklasRosenstein
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall; would be nice to have a test that checks if the version gets injected correctly into the workspace dependencies!
5a51b19 to
677a91b
Compare
8e3755c to
40c32af
Compare
40c32af to
5ea2697
Compare
1fc84d9 to
633dd22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an unhandled case in version injection task.
For a project with virtual manifest like this:
Kraken would not inject
versionandregistryattributes.This MR fixes it, by correctly injecting versions for dependencies declared in workspaces with virtual manifest.
Decisions:
_rawattribute to most manifest related classes, store raw JSON data there (without removing the handled fields)_rawand use a getter with deprecation warning for backward compatibilityto_jsonmethods could be simplified, as they can simply returnself._raw