Skip to content

Remove the keyFile option from the Google Cloud config array #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2025
Merged

Remove the keyFile option from the Google Cloud config array #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff269d5
Remove the `keyFile` option from the Google Cloud config array
jeromegamez Oct 12, 2025
8537b3f
Ignore deprecated method error
jeromegamez Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/Firebase/Factory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ public function createFirestore(?string $databaseName = null): Contract\Firestor
public function createStorage(): Contract\Storage
{
try {
$storageClient = new StorageClient($this->googleCloudClientConfig());
$storageClient = new StorageClient($this->googleCloudClientConfig()); // @phpstan-ignore method.deprecated
} catch (Throwable $e) {
throw new RuntimeException('Unable to create a StorageClient: '.$e->getMessage(), $e->getCode(), $e);
}
Expand Down Expand Up @@ -638,11 +638,6 @@ private function googleCloudClientConfig(): array
$config['credentialsFetcher'] = $credentials;
}

$serviceAccount = $this->getServiceAccount();
if ($serviceAccount !== null) {
$config['keyFile'] = $this->normalizeServiceAccount($serviceAccount);
}

return $config;
}

Expand Down
2 changes: 1 addition & 1 deletion src/Firebase/Firestore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ private function __construct(private readonly FirestoreClient $client)
public static function fromConfig(array $config): Contract\Firestore
{
try {
return new self(new FirestoreClient($config));
return new self(new FirestoreClient($config)); // @phpstan-ignore method.deprecated
} catch (Throwable $e) {
throw new RuntimeException('Unable to create a FirestoreClient: '.$e->getMessage(), $e->getCode(), $e);
}
Expand Down