add possibility to restrict all stations by wildcards in network/station #52
Conversation
megies
force-pushed
the
station_restriction_wildcards
branch
from
dea3de9 to
32e0874
Compare
|
Probably it's also a good idea to relax the length restrictions on the network/station code fields, at some point. New developments in SEED or StationXML will most likely allow longer codes in the future.. |
|
Looks pretty good - can you add a small test to this? ;-) Also maybe add a small sentence to the documentation at the bottom of this page: http://krischer.github.io/jane/waveforms/index.html |
megies
force-pushed
the
station_restriction_wildcards
branch
from
32e0874 to
e5e8286
Compare
|
Test is not perfect, as it uses what was there already, with only a single station in the inventory.. but at least it's something |
| station = models.CharField(max_length=5, db_index=True, | ||
| help_text=help_text) | ||
| users = models.ManyToManyField( | ||
| User, db_index=True, |
There was a problem hiding this comment.
I'm not sure if this has to be indexed - each index slows down the DB and I assume the other restrictions would already cut down the query enough so the user queries would be cheap? Not sure to be honest - might be worth to benchmark for a large database but the waveform table will be by far the biggest one so it has to reasonably fast.
There was a problem hiding this comment.
I didnt change the indexing, just added the help text.
There was a problem hiding this comment.
btw: changing the help_text requires a makemigrations too - even if it doesn't touch the database schema
There was a problem hiding this comment.
huh.. on my local jane the help text shows up immediately..
There was a problem hiding this comment.
sure - its working right away - but I bet you get also a new warning that a schemamigration is required ...
There was a problem hiding this comment.
where should this warning pop up? at least in the debug mode runserver I dont see anything..
There was a problem hiding this comment.
python manage.py migrate
should show something like
Your models have changes that are not yet reflected in a migration, and so won't be applied.
Run 'manage.py makemigrations' to make new migrations, and then re-run 'manage.py migrate' to apply them.
There was a problem hiding this comment.
Please also commit the migrations.
There was a problem hiding this comment.
tbh, the whole migrations stuff is still beyond me, I actually get errors due to some plugin changes when running python manage.py migrate, so hard to tell about warnings. usually I just scrap the whole DB and fill it in new right now (it's still pretty sandboxy)
|
Did you forget to push the tests? Also the new users field it not used currently. |
Yeah, forgot to commit the tests, so they weren't in the push. The users field is not new, I just added the help text. |
for waveforms help text changes
code.
Essentially makes it possible to hide all stations (or specific networks) for most users while making visible for some other users.
Restrictions seem to be untested in REST interface.. that's clearly something that should be done