Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests and docs integrating metadata_profile #1541

Merged
merged 5 commits into from
Mar 21, 2025

Conversation

shreyabiradar07
Copy link
Contributor

@shreyabiradar07 shreyabiradar07 commented Mar 18, 2025

Description

This PR has following changes:

  • Updates dsmetadata and bulk API input JSONs in local monitoring adding new metadata_profile field
  • Updates documentation to include metadata_profile field

Note: Has dependency on PR #1444 to be merged first.

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes
  • Tests update

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite: Local monitoring

Test Configuration

  • Kubernetes clusters tested on: Openshift

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Test results:
PR_1541_local_monitoring_tests.zip

docker image: quay.io/shbirada/integrate_metadata_api:v1

@chandrams
Copy link
Contributor

@shreyabiradar07 In the logs, I see tests failing with the below errors:

Bulk test

       # Make the GET request without verbose
>       response_basic = get_bulk_job_status(job_id,False)
E       NameError: name 'get_bulk_job_status' is not defined

listrecommendations test

        response = generate_recommendations(exp_name)
>       assert response.status_code == SUCCESS_STATUS_CODE
E       assert 500 == 201
E        +  where 500 = <Response [500]>.status_code

Can you rebase and check these.

@shreyabiradar07
Copy link
Contributor Author

Latest local monitoring test results: PR_1541_local_monitoring_tests.zip

************************************** done *************************************
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Overall summary of the tests ~~~~~~~~~~~~~~~~~~~~~~~
Total time taken to perform the test 3251 seconds
Total Number of test suites performed 1
Total Number of tests performed 126
Total Number of tests passed 124
Total Number of tests failed 2

Check below logs for failed test cases:
                                        local_monitoring_tests

*********************************************************************************
########################################################################

Copy link
Contributor

@chandrams chandrams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandrams chandrams merged commit ef18c4a into kruize:mvp_demo Mar 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation local_monitoring test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants