Skip to content

Commit f09744d

Browse files
committed
Merge tag 'misc-fixes-pull-request' of https://gitlab.com/berrange/qemu into staging
* Print error with f32 audio format in wav backend instead of abort * Drop redundant listener name suffix * Update libvirt mailing list address * Cleanup RSA key error paths * Fix CPU uarch ABI script QMP command calling # -----BEGIN PGP SIGNATURE----- # # iQIzBAABCAAdFiEE2vOm/bJrYpEtDo4/vobrtBUQT98FAmVKiwoACgkQvobrtBUQ # T9+SjxAAmDBWE9WI/eKZEb3QVNi3W90bVNIKMSdu7DMaqSPGMe6dcNeJy6kHL2ud # EgdvtKgWq5wwFDojrYiUB75tSFGP7InK2a7EN7t60kE/XxtqR/fvLo11d+gUI7Z6 # vetsHLtDYEs3Hr/75qg1/ock/G1TxzlJknzww1zDjQrwFSaJnOWDdY+RSRGTwEho # PRfFRkIDZqs3LAKyjRdiYWms90vogG2Bwygmo/mirgta9Lmkz9WC9SN/EqOvOBOE # NyaO84xu38U3JwN5d9w4MFdgayFNRYTcvTu8J0NdHLp16CYBViGecIGb4deDYN0U # jhmfKChyr0tJucPsRndXQU2KFusePjiSWEsG9FdbpXdjFGIwinJUDKOaHI4Kk9pc # stGCwb8+9Ec0e31JqtMBd5VeoToK8UsthVqAx1brnXv9K5liSXS7nyFPwNp/SMi4 # UNpjawSItAHEgc6VzqDNZY+dGtueMZmM0lf7cMLho3BgAeyTbr1NuwOIJx28JP2E # NnkAwDHjj9u1mkhRM7BbgBzGq006naWP8V6dCGQSH+/D0C9P3yzs7XLtvwtUDO3P # DalGRsazT+o+pyuyw0uyV2z6GuLAl9ZhI0MJCgIxsmASdxANxMcIaCrs1yc0IG2A # y16e4/Ic/FzqkbwkkBy3tkDF7vI0++1MuqmcWki+RFz1hzqmY+Y= # =KHzn # -----END PGP SIGNATURE----- # gpg: Signature made Wed 08 Nov 2023 03:07:54 HKT # gpg: using RSA key DAF3A6FDB26B62912D0E8E3FBE86EBB415104FDF # gpg: Good signature from "Daniel P. Berrange <[email protected]>" [full] # gpg: aka "Daniel P. Berrange <[email protected]>" [full] # Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF * tag 'misc-fixes-pull-request' of https://gitlab.com/berrange/qemu: scripts/cpu-x86-uarch-abi.py: Fix parameter error of cmd MAINTAINERS: update libvirt devel mailing list address audio: don't abort on f32 audio format in wav backend io: Stop appending -listen to net listeners crypto/rsakey-builtin.c.inc: Clean up two error paths Signed-off-by: Stefan Hajnoczi <[email protected]>
2 parents 44ad47b + 3e7ebf5 commit f09744d

File tree

4 files changed

+9
-11
lines changed

4 files changed

+9
-11
lines changed

audio/wavaudio.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,10 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as,
9797
dolog ("WAVE files can not handle 32bit formats\n");
9898
return -1;
9999

100+
case AUDIO_FORMAT_F32:
101+
dolog("WAVE files can not handle float formats\n");
102+
return -1;
103+
100104
default:
101105
abort();
102106
}

crypto/rsakey-builtin.c.inc

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,13 @@ static QCryptoAkCipherRSAKey *qcrypto_builtin_rsa_public_key_parse(
8888
goto error;
8989
}
9090
if (seq_length != 0) {
91+
error_setg(errp, "Invalid RSA public key");
9192
goto error;
9293
}
9394

9495
return rsa;
9596

9697
error:
97-
if (errp && !*errp) {
98-
error_setg(errp, "Invalid RSA public key");
99-
}
10098
qcrypto_akcipher_rsakey_free(rsa);
10199
return NULL;
102100
}
@@ -169,15 +167,13 @@ static QCryptoAkCipherRSAKey *qcrypto_builtin_rsa_private_key_parse(
169167
return rsa;
170168
}
171169
if (seq_length != 0) {
170+
error_setg(errp, "Invalid RSA private key");
172171
goto error;
173172
}
174173

175174
return rsa;
176175

177176
error:
178-
if (errp && !*errp) {
179-
error_setg(errp, "Invalid RSA private key");
180-
}
181177
qcrypto_akcipher_rsakey_free(rsa);
182178
return NULL;
183179
}

io/net-listener.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,7 @@ void qio_net_listener_add(QIONetListener *listener,
109109
QIOChannelSocket *sioc)
110110
{
111111
if (listener->name) {
112-
char *name = g_strdup_printf("%s-listen", listener->name);
113-
qio_channel_set_name(QIO_CHANNEL(sioc), name);
114-
g_free(name);
112+
qio_channel_set_name(QIO_CHANNEL(sioc), listener->name);
115113
}
116114

117115
listener->sioc = g_renew(QIOChannelSocket *, listener->sioc,

scripts/cpu-x86-uarch-abi.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@
9494

9595
for name in sorted(names):
9696
cpu = shell.cmd("query-cpu-model-expansion",
97-
{ "type": "static",
98-
"model": { "name": name }})
97+
type="static",
98+
model={ "name": name })
9999

100100
got = {}
101101
for (feature, present) in cpu["model"]["props"].items():

0 commit comments

Comments
 (0)