Handle LoadOrCreate deserialization of JSON null via existing recovery path - #296
Merged
matt-edmondson merged 2 commits intoSep 13, 2026
Merged
Conversation
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix NullReferenceException in LoadOrCreate method
Handle Sep 13, 2026
LoadOrCreate deserialization of JSON null via existing recovery path
matt-edmondson
marked this pull request as ready for review
September 13, 2026 12:05
|
matt-edmondson
deleted the
copilot/fix-nullreferenceexception-load-or-create
branch
September 13, 2026 12:15
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



AppData<T>.LoadOrCreate(...)could throwNullReferenceExceptionwhen the settings file contained literal JSONnullbecauseDeserialize<T>returnednullwithout throwing. This change treats that case as recoverable corruption so the existing backup/new-instance flow is used consistently.Deserialization null handling
LoadOrCreateto convert anulldeserialization result intoJsonException, keeping control flow inside the existing corruption recovery logic.Regression coverage
null, assertingLoadOrCreate()recovers to a valid default instance rather than crashing.LoadOrCreatethrowsNullReferenceExceptioninstead of recovering when the settings file contains JSONnull#295