Move to the renamed ktsu.ImGui.NodeEditor package - #20
Merged
Conversation
ImGuiApp renamed ktsu.ImGuiNodeEditor to ktsu.ImGui.NodeEditor in 3.19.0, bringing the node editor in line with every other ImGui-facing package in that suite. The old id is not published beyond 3.18.0, so staying on it means never taking another node editor release. The rename touches the package id, the namespace, and the prose that names either. No API changed, so the graph code itself is untouched. Pinning the node editor at 3.19.0 forces its siblings up with it — a mixed set trips NU1605 — and 3.19.0 also split the tokenizing half of ktsu.ImGui.SyntaxHighlighting out into ktsu.SyntaxHighlighting. The renderer entry points stayed put, so only the test that names HighlightedToken and TokenKind needed the new namespace; the preview pane's SyntaxHighlightConfig and Render are where they were. Verified with a Release build and the full Coder.Test suite: 327 passed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015qVmjxGLzVE2mZctNNjSJC
Directory.Packages.props conflicted: main's resizable-panes work added ktsu.ImGui.Widgets and Silk.NET.Windowing.Common in the same block this branch renamed and bumped. Kept both — the new entries stay, with ktsu.ImGui.Widgets moved to 3.19.0 alongside the rest of the suite so the set stays consistent. Main also added a fresh `using ktsu.ImGuiNodeEditor;` to AstGraphEditorTests, which merged cleanly because the line was new rather than conflicting; renamed it too. Verified with a Release build and the full Coder.Test suite: 329 passed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015qVmjxGLzVE2mZctNNjSJC
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImGuiApp renamed
ktsu.ImGuiNodeEditortoktsu.ImGui.NodeEditorin 3.19.0 (ktsu-dev/ImGuiApp#356), bringing the node editor in line with every other ImGui-facing package in that suite. The old id stops at 3.18.0, so staying on it means never taking another node editor release.The rename
The package id, the namespace, and the prose that names either:
Directory.Packages.props,Coder.Graph/Coder.Graph.csprojCoder.Graphisnet10.0-onlyCoder.Graph/AstGraph.cs,AstGraphEditor.csusing ktsu.ImGui.NodeEditor;Coder.Test/Graph/ktsu.ImGui.NodeEditor.NodeinAstGraphEditorTests.csREADME.md,CLAUDE.mdNo API changed in the move, so the graph code itself is untouched.
The version bump that comes with it
ktsu.ImGui.NodeEditoronly exists from 3.19.0, and pinning it there forces its siblings up with it — a mixed set trips NU1605, since the node editor depends onktsu.ImGui.Appandktsu.ForceDirectedLayoutat its own version. Soktsu.ImGui.App,ktsu.ImGui.App.Testing,ktsu.ImGui.SyntaxHighlighting,ktsu.ImGui.Widgetsandktsu.ForceDirectedLayoutall move 3.18.0 → 3.19.0.That bump carries one other breaking change into this repo. 3.19.0 split the tokenizing half of
ktsu.ImGui.SyntaxHighlightingout into a renderer-agnosticktsu.SyntaxHighlighting(ktsu-dev/ImGuiApp#357). The renderer entry points stayed where they were, soCoderEditorApp'sSyntaxHighlightConfigandImGuiSyntaxHighlighting.Renderneeded nothing; onlyGeneratedCodeHighlightingTests, which namesHighlightedTokenandTokenKind, needed the new namespace added to its usings.Merge with main
#19 landed while this was open and touched the same block of
Directory.Packages.props, addingktsu.ImGui.WidgetsandSilk.NET.Windowing.Common. Both are kept, withktsu.ImGui.Widgetsmoved to 3.19.0 alongside the rest of the suite. #19 also added a freshusing ktsu.ImGuiNodeEditor;toAstGraphEditorTests— a new line rather than a conflicting one, so it merged cleanly and needed renaming afterwards.Verification
dotnet build -c Releaseis clean and the fullCoder.Testsuite passes on the merged head — 329 tests, 0 failed.🤖 Generated with Claude Code
https://claude.ai/code/session_015qVmjxGLzVE2mZctNNjSJC