Take the ktsu ImGui suite at 3.28.0 - #39
Merged
Merged
Conversation
3.28.0 adds hover highlighting to the node editor: hovering a node colours the links that meet it, and the link under the pointer is drawn over the nodes it passes behind. Both are on by default, so the graph editor gets them from the bump alone. It also makes a pin's connection capacity its own property, and adds GetDownstream/GetUpstream to the engine. Coder builds clean and its 373 tests pass on the new packages. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KkR28NfEw1iVW73A9A6q7u
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the six ktsu ImGui suite packages from 3.26.0 to 3.28.0:
ktsu.ImGui.App,ktsu.ImGui.App.Testing,ktsu.ImGui.Widgets,ktsu.ImGui.SyntaxHighlighting,ktsu.ImGui.NodeEditorandktsu.ForceDirectedLayout.What Coder gets
3.28.0 (ktsu-dev/ImGuiApp#377) adds hover behaviour to the node editor, and
AstGraphEditorpicks it up from the bump alone since both are on by default:Two further additions are available but not wired up here, since neither changes behaviour on its own:
NodeEditorRenderer.HighlightDownstreamOnNodeHover(off by default) highlights everything the hovered node's value reaches. The editor's toolbar would be the natural home for it if it is wanted.NodeEditorEngine.GetDownstream/GetUpstreamwalk the graph forward and backward, and pins now carry their own connection capacity (AllowsMultipleConnections).One fix in the same release is worth knowing about because
AstGraphEditorcalls it:RenderDebugOverlaysdrew on the window draw list, which is composited underneath the node editor's child window, so its force and velocity vectors — which start at node centres — were hidden by the nodes they describe. They now draw on the foreground list and are actually visible.Testing
dotnet build Coder.sln -c Release— clean, no warnings.dotnet test Coder.sln -c Release— 373 passed, 0 failed. No source changes were needed.🤖 Generated with Claude Code
https://claude.ai/code/session_01KkR28NfEw1iVW73A9A6q7u
Generated by Claude Code