Follow the exemplar's rename - #47
Merged
Merged
Conversation
Holotype spells its type names out now, so holo::Vec3 is holo::Vector3 and vec.hpp is vector.hpp. The acceptance expectation here is the document's own text, so it moves with it. Verified the expectation is still byte-identical to the document's first section, tabs expanded, rather than only that the test passes. 485 tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AhoPJ5AbxP8QEBNxPQYEPk
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holotype spells its type names out now (matt-edmondson/Holotype#7):
holo::Vec3isholo::Vector3, andvec.hppisvector.hpp.ExemplarHeaderTests' expectation is the document's own text, character for character, so it moves with the document. Nothing in the AST or the generators changes — this is the acceptance target moving, which is exactly the coupling that test exists to have.I checked the expectation against the document's first section directly, tabs expanded to the four spaces the writer emits, rather than only checking that the test still passes: the two are identical.
485 tests pass, 0 warnings, 0 errors.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AhoPJ5AbxP8QEBNxPQYEPk
Generated by Claude Code