Move to the renamed ktsu.ImGui.NodeEditor package - #147
Merged
Conversation
ImGuiApp renamed ktsu.ImGuiNodeEditor to ktsu.ImGui.NodeEditor in 3.19.0, bringing the node editor in line with every other ImGui-facing package in that suite. The old id is not published beyond 3.18.0, so staying on it means never taking another node editor release. The rename touches the package id, the namespace, and the prose that names either. No API changed, so ClassGraphView's graph code is untouched. Pinning the node editor at 3.19.0 forces the rest of the suite up with it from 3.16.11 — a mixed set trips NU1605, as ktsu.ForceDirectedLayout did first through the node editor's own dependency on it. CHANGELOG.md keeps the old name: it is a record of what was released at the time, not a reference that has to resolve. Verified with a Release build and the test suites on net10.0: 404 passed, SchemaEditor.Test included. The net8.0 and net9.0 heads of Schema.Test could not launch here — only the .NET 10 runtime is installed in this environment — and are untouched by this change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015qVmjxGLzVE2mZctNNjSJC
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImGuiApp renamed
ktsu.ImGuiNodeEditortoktsu.ImGui.NodeEditorin 3.19.0 (ktsu-dev/ImGuiApp#356), bringing the node editor in line with every other ImGui-facing package in that suite. The old id stops at 3.18.0, so staying on it means never taking another node editor release.The rename
The package id, the namespace, and the prose that names either:
Directory.Packages.props,SchemaEditor/SchemaEditor.csprojSchemaEditor/ClassGraphView.csusing ktsu.ImGui.NodeEditor;, and the class summary that names the engineSchemaEditor.Test/ClassGraphTests.csNo API changed in the move, so the graph code itself is untouched.
CHANGELOG.mdkeeps the old name — it records what was released at the time, not a reference that has to resolve.The version bump that comes with it
ktsu.ImGui.NodeEditoronly exists from 3.19.0, and pinning it there forces the rest of the suite up with it from 3.16.11 — a mixed set trips NU1605.ktsu.ForceDirectedLayoutproved that first: the node editor depends on it directly, so leaving it at 3.16.11 failed restore with a downgrade error before anything compiled.ktsu.ImGui.App,ktsu.ImGui.App.Testing,ktsu.ImGui.Popups,ktsu.ImGui.Probes,ktsu.ImGui.Widgets,ktsu.ImGui.Stylerandktsu.ForceDirectedLayoutall move 3.16.11 → 3.19.0.ktsu.NodeGraphversions independently and stays at 1.0.0.Verification
dotnet build -c Releaseis clean and thenet10.0test heads pass — 404 tests, 0 failed,SchemaEditor.Testincluded, so the class graph view is exercised against the renamed package.The
net8.0andnet9.0heads ofSchema.Testcould not launch in the environment I built in, which has only the .NET 10 runtime installed. Nothing in this change touches those targets, and CI runs them normally.🤖 Generated with Claude Code
https://claude.ai/code/session_015qVmjxGLzVE2mZctNNjSJC
Generated by Claude Code