Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing comments for clarity (part 1) #3932

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

thomasvn
Copy link
Member

What does this PR change?

Begin establishing design standards. Standardize comments and configuration definitions.

Does this PR rely on any other PRs?

Continuing work from #3699

How does this PR impact users? (This is the kind of thing that goes in release notes!)

N/A

Links to Issues or tickets this PR addresses or fixes

N/A

What risks are associated with merging this PR? What is required to fully test this PR?

N/A

How was this PR tested?

No material differences observed for the default configurations. The only difference found was in this line.

git checkout develop
git pull
helm template ./cost-analyzer > orig.yaml

git checkout thomasn/comments-pt1
helm template ./cost-analyzer > pr.yaml

diff orig.yaml pr.yaml

Have you made an update to documentation? If so, please provide the corresponding PR.

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant