Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce iSulad. #526

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce iSulad. #526

wants to merge 1 commit into from

Conversation

luomengY
Copy link
Member

@luomengY luomengY commented Mar 26, 2024 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

/features

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fisherxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2024
wbc6080
wbc6080 reviewed May 10, 2024
View reviewed changes
docs/setup/prerequisites/runtime.md Outdated
Comment on lines 297 to 294

If you are installing on an OpenEuler system, you can directly install through yum by adding OpenEuler's yum repository:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you are installing on an OpenEuler system, you can directly install through yum by adding OpenEuler's yum repository:
- install on OpenEuler system
Adding OpenEuler's yum repository:
.......
Install iSulad with yum:
.......

Would it be better to add a subtitle here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

docs/setup/prerequisites/runtime.md Outdated
```bash
$ yum install -y iSulad
```
If your system is Centos, you can install iSulad by running [scripts]( https://gitee.com/openeuler/iSulad/blob/master/docs/build_docs/guide/script/install_iSulad_on_Centos_7.sh).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If your system is Centos, you can install iSulad by running [scripts]( https://gitee.com/openeuler/iSulad/blob/master/docs/build_docs/guide/script/install_iSulad_on_Centos_7.sh).
If your system is CentOS, you can install iSulad by running [scripts]( https://gitee.com/openeuler/iSulad/blob/master/docs/build_docs/guide/script/install_iSulad_on_Centos_7.sh).

It seems that the standard name is CentOS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

docs/setup/prerequisites/runtime.md Outdated
$ cd iSulad/docs/build_docs/guide/script
$ sudo ./install_iSulad_on_Centos_7.sh
```
If your system is Ubuntu, you can install iSulad by running [scripts]( https://gitee.com/openeuler/iSulad/blob/master/docs/build_docs/guide/script/install_iSulad_on_Ubuntu_20_04_LTS.sh).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If your system is Ubuntu, you can install iSulad by running [scripts]( https://gitee.com/openeuler/iSulad/blob/master/docs/build_docs/guide/script/install_iSulad_on_Ubuntu_20_04_LTS.sh).
- install on Ubuntu system
......

ditto

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

docs/setup/prerequisites/runtime.md Outdated
Comment on lines 316 to 314
$ git clone https://gitee.com/openeuler/iSulad.git
$ cd iSulad/docs/build_docs/guide/script
$ sudo ./install_iSulad_on_Centos_7.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small question, does this script depend on the entire iSulad repo when executed? If it is not dependent, can we download this file directly instead of cloning the entire code base? We can download only install_iSulad_on_Centos_7.sh through this link https://gitee.com/openeuler/iSulad/raw/master/docs/build_docs/guide/script/install_iSulad_on_Centos_7.sh

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes ,only depend on scprit

docs/setup/prerequisites/runtime.md Outdated
```bash
$ systemctl enable isulad
$ systemctl restart isulad
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also provide a Chinese version of the document?

Shelley-BaoYue
Shelley-BaoYue reviewed May 25, 2024
View reviewed changes
docs/setup/prerequisites/runtime.md Outdated
@@ -12,6 +12,7 @@ This page provides an outline of how to use several common container runtimes wi
- [docker](#docker-engine)
- [Kata containers](#kata-containers)
- [Virtlet](#Virtlet)
- [iSulad](#iSulad)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [iSulad](#iSulad)
- [iSulad](#isulad)

It needs to be in lowercase, otherwise it won't jump

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

docs/setup/prerequisites/runtime.md Outdated
@@ -12,6 +12,7 @@ This page provides an outline of how to use several common container runtimes wi
- [docker](#docker-engine)
- [Kata containers](#kata-containers)
- [Virtlet](#Virtlet)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Virtlet](#Virtlet)
- [Virtlet](#virtlet)

Please help modify it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@luomengY luomengY force-pushed the cri branch 5 times, most recently from fbd6b86 to 12a4ad9 Compare June 7, 2024 06:04
@kubeedge-bot kubeedge-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2024
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 30, 2024
@luomengY
Introduce iSulad.
2d74506 
Signed-off-by: luomengY <[email protected]>
@luomengY
Copy link
Member Author

@wbc6080 @Shelley-BaoYue @fisherxu tks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shelley-BaoYue Shelley-BaoYue Shelley-BaoYue left review comments

@wbc6080 wbc6080 wbc6080 left review comments

@dingyin dingyin Awaiting requested review from dingyin

@fisherxu fisherxu Awaiting requested review from fisherxu

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luomengY @kubeedge-bot @wbc6080 @Shelley-BaoYue