-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Improving the install with binary docs #558
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: GitHub <[email protected]>
@wbc6080 @fujitatomoya I am looking for your suggestions here as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fix lgtm with a couple of minor nitpics.
btw, why do we need to maintain? this is not even recommended procedure to install KubeEdge, what is the use case for this procedure? even with testing environment, we should not set up the KubeEdge with binaries? if that is so, probably we can just remove this page? i may be missing some cases, not sure about the history...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is mainly for developers. After modifying some codes of kubeedge, you can directly start the kubeedge cluster in binary mode for testing. I think it is necessary to keep this part, otherwise developers will not be able to check whether the subsequent kubeedge can work normally after the modifications.
Signed-off-by: GitHub <[email protected]>
added all your suggestions, Please also confirm that we are only using beta version of device crd and other crds need not be updated. |
@wbc6080 thanks for clarification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@fujitatomoya @wbc6080 please approve this PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. (i do not have the permission though...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can wait for an approver to merge it
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fujitatomoya, wbc6080 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the new behavior (if this is a feature change)?
this is one among series of PRs planned to improve and rewrite some parts of documentation. Here I improved the "install with binary" docs.
Works towards solving #533