Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implemented PartnerCard Component and Integrated it into Partners Page – Seeking Suggestions #684

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Asp-irin
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:

Fixes #

  • What kind of change does this PR introduce?
    This PR enhances the UI by improving the presentation of the partners list, ensuring a clean and theme-aligned design.

  • What is the current behavior?
    The partners page currently displays all partners in a table format, which results in poor UX and lacks responsiveness.

image
image

Resposive issue:
image
image

  • What is the new behavior?
    The table has been replaced with a card-based layout, improving both visual appeal and user experience. The new design includes hover animations to enhance interactivity and ensures proper alignment with the current theme. Additionally, a reusable PartnerCard component has been created to promote maintainability and responsiveness across different screen sizes.

partners_light_hovered
partners_light
partners_Dark

Responsive views:
image
image

  • Does this PR introduce a breaking change?
    No

  • Other information:
    Feedback was collected from 10 individuals, and all 10 preferred the card-based layout over the table-based format.

@kubeedge-bot kubeedge-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fisherxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot
Copy link
Collaborator

Welcome @Asp-irin! It looks like this is your first PR to kubeedge/website 🎉

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 12, 2025
@Asp-irin
Copy link
Author

Asp-irin commented Feb 12, 2025

To Do:

  • Update the logo links for the existing partners.
  • Update the partners documentation to specify the logo requirement and request modifications in the front matter of partners.mdx.
  • Confirm with the mentors(@Shelley-BaoYue, @fisherxu and @anvithks) whether the enhancements align with the goal and gather their suggestions for the remaining designs.

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2025
@kubeedge-bot
Copy link
Collaborator

@Asp-irin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants