-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Footer UI improvement #688
base: master
Are you sure you want to change the base?
Conversation
Hi @Shelley-BaoYue , this pr is a sub of my proposal for LFX 2025 mentorship. currently we have a CNCF logo as a footer, so this pr changes it to the actual footer and move the CNCF logo to a section in homepage. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, i thought of initially using a glassmorphism around the icon but it might affect the branding so i left it that way, I will change the bg color to a bit darker blue cc @wbc6080 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: TenzDelek <[email protected]>
Signed-off-by: TenzDelek <[email protected]>
9bfcfda
to
fb87927
Compare
Which issue(s) this PR fixes:
Fixes #
UI UPDATE
there is footer missing
added footer for the website
No
Screenshots
n mobile: