Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Footer UI improvement #688

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TenzDelek
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:

Fixes #

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

UI UPDATE

  • What is the current behavior? (You can also link to an open issue here)

there is footer missing

  • What is the new behavior (if this is a feature change)?

added footer for the website

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

Screenshots

before:

Screenshot 2025-02-13 at 12 03 55 AM

After:

Screenshot 2025-02-12 at 11 53 08 PM

n mobile:

ss

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 12, 2025
@TenzDelek
Copy link
Author

TenzDelek commented Feb 12, 2025

Hi @Shelley-BaoYue , this pr is a sub of my proposal for LFX 2025 mentorship. currently we have a CNCF logo as a footer, so this pr changes it to the actual footer and move the CNCF logo to a section in homepage.

PTAL
/assign @Shelley-BaoYue

Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to cause problems with the kubeedge icon display. Do you need to adjust the color?
image

@TenzDelek
Copy link
Author

This seems to cause problems with the kubeedge icon display. Do you need to adjust the color? image

sure, i thought of initially using a glassmorphism around the icon but it might affect the branding so i left it that way, I will change the bg color to a bit darker blue cc @wbc6080

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shelley-baoyue after the PR has been reviewed.
You can assign the PR to them by writing /assign @shelley-baoyue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants