-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog: Add post on leveraging Katib for efficient RAG optimization. #161
Blog: Add post on leveraging Katib for efficient RAG optimization. #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so great! One small nit: can you break up the text so that there are line breaks around every 80 characters or so? It'll help comment individual sections.
FYI @andreyvelich we can put this under GenAI page |
00ac27d
to
5f6d99f
Compare
I'm not able to replicate the build error locally, trying to dig into it. Looks like I maybe missing some configuration, if someone has seen this issue before, that'd be super helpful. |
@tarekabouzeid did you encounter any issues here? |
No, i haven't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this great blog post @varshaprasad96!
I left a few comments.
/assign @varodrig @kubeflow/wg-training-leads @Electronic-Waste @helenxie-bit @akgraner
Please help us with the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this great blog post!
LGTM form my PoV
7309b0d
to
f003d79
Compare
@varshaprasad96 @andreyvelich is this ready to go? |
There is just one restructuring I need to do to make it easier from ML users perspective. Testing it right now, will push the changes in a few mins. |
5a0b36d
to
57421b9
Compare
@andreyvelich Updated with the changes to use Katib SDK, could you take a look please. Thanks! |
ground_truth = "" # Example: "The Eiffel Tower is a famous landmark in Paris." | ||
|
||
# Run the RAG pipeline with hyperparameters from Katib | ||
bleu_score = evaluate(query, ground_truth, top_k, temperature) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should say that all imports and functions (e.g. evaluate()
) should be defined under the objective
function.
Similar to KFP Lightweight Python Component, the function must be self-contained: https://www.kubeflow.org/docs/components/pipelines/user-guides/components/lightweight-python-components/#python-function-requirements.
Users can also do something like this:
def objective(parameters):
from evaluate import eval
....
But in that case, evaluate module should be accessible in Katib Trials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've restructured the content to talk about the objective function a bit more clearly now
Signed-off-by: Varsha Prasad Narsing <[email protected]>
57421b9
to
176cb07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thank you so much for the updates!
/lgtm
/assign @franciscojavierarceo @tarekabouzeid @tenzen-y @Electronic-Waste
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: franciscojavierarceo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: #160