Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up with another way overdue PR, for adding @annajung as a reviewer in both repo wide and in
/contrib
sub-directory.Anna has made huge contributions to the manifests repo throughout the last 2 years. Some highlights:
/contrib
repo Tracking for/contrib
components evaluation and clean up #2311The above contributions touch all the pillars of the manifests repo:
The above list, plus contributions on the common components owned by manifests (Istio, Knative, Cert Manager etc), is what I consider the main areas for promoting someone as an approver to the repo. And of course having a track record of being able to efficiently communicate and lead efforts in this areas.
So with the above I propose Anna to be a reviewer for both
/contrib
and for the whole repo/cc @kubeflow/wg-manifests-leads
NOTE: I'm removing the current reviewers, since they are already in the approvers list