Skip to content

Conversation

paulovmr
Copy link

@paulovmr paulovmr commented Jul 4, 2025

By adding this new lint rule, the npm run test command will fail when there are spelling errors in the source code (e.g. error Unknown word: "didn" @cspell/spellchecker)

This can be bypassed by adding the word to the workspaces/frontend/config/cspell-ignore-words.txt file.

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Jul 4, 2025
@google-oss-prow google-oss-prow bot added the area/frontend area - related to frontend components label Jul 4, 2025
@google-oss-prow google-oss-prow bot requested review from ederign and kimwnasptd July 4, 2025 16:52
@google-oss-prow google-oss-prow bot added area/v2 area - version - kubeflow notebooks v2 size/XXL labels Jul 4, 2025
@paulovmr
Copy link
Author

paulovmr commented Jul 4, 2025

/ok-to-test

@paulovmr paulovmr force-pushed the notebooks-v2-added-cspell branch from 61d0c6c to 5e304aa Compare July 4, 2025 16:59
@paulovmr paulovmr force-pushed the notebooks-v2-added-cspell branch from 5e304aa to 0de0f8f Compare July 4, 2025 17:01
Copy link

@caponetto caponetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ederign
Copy link
Member

ederign commented Jul 7, 2025

/approve
/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 825ed0e into kubeflow:notebooks-v2 Jul 7, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Jul 7, 2025
Noa-limoy pushed a commit to Noa-limoy/notebooks that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/XXL
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants