feat: Migrate TWA test-related workflows #627

yehudit1987 · 2025-09-30T11:18:23Z

Migrate frontend tests, multi-arch build, and integration test workflows

Resolve issue [TASK] Migrate TWA test-related workflows from kubeflow/kubeflow to notebooks-v1 branch #589

andyatmiami

Really nice investigations/implementations here @yehudit1987 - but for the immediate needs of notebooks-v1 migration - I would prefer we dial back some of these changes to align more with the "status quo" of how kubeflow/kubeflow implemented these workflows.

components/crud-web-apps/tensorboards/frontend/package-lock.json

.github/workflows/twa_multi_arch_test.yaml

.github/workflows/twa_frontend_tests.yaml

andyatmiami

Hey @yehudit1987 - thank you for these changes...

Things look pretty good - but would like for yourself and/or @kimwnasptd to weigh in on the observations I have included on this PR for discussion.

andyatmiami · 2025-10-20T17:04:51Z

components/crud-web-apps/tensorboards/frontend/package.json

    "@typescript-eslint/eslint-plugin": "4.28.2",
    "@typescript-eslint/parser": "4.28.2",
-    "cypress": "~13.13.1",
+    "cypress": "14.1.0",


I have confirmed this 14.1.0 version does fix the connectivity issues b/w Cypress and Firefox... but unfortunately leads to this message cropping up in build logs:

npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: '[email protected]', npm WARN EBADENGINE required: { node: '^18.0.0 || ^20.0.0 || >=22.0.0' }, npm WARN EBADENGINE current: { node: 'v16.20.2', npm: '8.19.4' } npm WARN EBADENGINE }

By all accounts this WARN is not affecting anything - but wanted to surface this so we can discuss what to do.

I am also unclear if we want to fix the version of Cypress to 14.1.0 - or use a qualifier like ^ or ~

Regarding the warning, upgrading the Node version to 18 or 20 would resolve it. this mainly impacts CI/CD environments, so there’s likely no real harm. Alternatively, we could just ignore the warning since it doesn’t affect runtime behavior.

As for the version qualifier, I’m not an expert here, but I’d lean toward using ~ since it allows patch updates while avoiding unexpected minor version changes, a safer middle ground than using ^.

I'd personally be OK with fixing the version to 14.1.0. And to cross-reference our discussion in the other PR as well #625 (comment)

Hey @kimwnasptd and @andyatmiami.
I’ve tested the suggested changes from the other PR. I kept the Cypress version pinned as it was and also pinned the tough-cookie version as recommended.

For this PR’s requirements, it wasn’t strictly necessary, but as expected, it didn’t break anything and helps keep things aligned with the other PR and consistent across the project.
Was tested in the attached - https://github.com/yehudit1987/notebooks/actions/runs/18817889000

andyatmiami · 2025-10-20T17:07:02Z

.github/workflows/twa_integration_test.yaml

+        make docker-build
+
+    - name: Install KinD
+      run: ./components/testing/gh-actions/install_kind.sh


While not directly related to changes introduced in this PR - given the AWS outage today - I am seeing issues trying to retrieve the kind binary referenced in install_kind.sh

➜ Downloads/ $ curl -vL -o kind "https://kind.sigs.k8s.io/dl/v0.22.0/kind-linux-amd64" % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0* Host kind.sigs.k8s.io:443 was resolved. * IPv6: 2600:1f18:16e:df01::259, 2600:1f18:16e:df01::258 * IPv4: 18.208.88.157, 98.84.224.111 * Trying 18.208.88.157:443... * Trying [2600:1f18:16e:df01::259]:443... * Immediate connect fail for 2600:1f18:16e:df01::259: No route to host * Trying [2600:1f18:16e:df01::258]:443... * Immediate connect fail for 2600:1f18:16e:df01::258: No route to host 0 0 0 0 0 0 0 0 --:--:-- 0:01:09 --:--:-- 0

It seems GitHub also hosts this binary and it available here:

https://github.com/kubernetes-sigs/kind/releases/download/v0.22.0/kind-linux-amd64

And I have confirmed its presently accessible:

% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 6245k 100 6245k 0 0 17.4M 0 --:--:-- --:--:-- --:--:-- 17.4M

Should install_kind.sh be updated to use this alternative location?

I guess this wondering depends on the answer to the question which of the two is more reliable in general?

andyatmiami · 2025-10-20T18:39:56Z

/ok-to-test

andyatmiami

/lgtm

Thanks for all this work @yehudit1987 - appreciate your responsiveness and diligence in working through issues in this PR (and taking lessons learned to help others facing similar issues 💯 )

I'm comfortable with the changes and have verified the workflows behave as expected.

Tested on my fork:

andyatmiami#59

kimwnasptd · 2025-10-28T15:04:30Z

Thank you so much for this effort @yehudit1987!

/approve

google-oss-prow · 2025-10-28T15:04:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kimwnasptd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kimwnasptd · 2025-10-28T15:06:46Z

There seems to be a conflict with the releasing/version/VERSION file. Let's rebase on top of the latest notebooks-v1 branch to resolve the conflict

Signed-off-by: Yehudit Kerido <[email protected]>

andyatmiami · 2025-10-28T17:16:18Z

/lgtm

latest commit simply is a result of a rebase to resolve a merge conflict in the VERSION file.

github-project-automation bot added this to Kubeflow Notebooks Sep 30, 2025

github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Sep 30, 2025

google-oss-prow bot added the do-not-merge/work-in-progress label Sep 30, 2025

google-oss-prow bot requested a review from kimwnasptd September 30, 2025 11:18

google-oss-prow bot added the area/ci area - related to ci label Sep 30, 2025

google-oss-prow bot requested a review from thesuperzapper September 30, 2025 11:18

google-oss-prow bot added the size/L label Sep 30, 2025

yehudit1987 force-pushed the feat/migrate_twa_tests branch 3 times, most recently from 01e48e4 to a5bfa91 Compare October 5, 2025 08:41

google-oss-prow bot added area/backend area - related to backend components area/frontend area - related to frontend components area/v1 area - version - kubeflow notebooks v1 size/XXL and removed size/L labels Oct 5, 2025

yehudit1987 force-pushed the feat/migrate_twa_tests branch 3 times, most recently from 8b9b78f to 28f1111 Compare October 5, 2025 09:00

yehudit1987 marked this pull request as ready for review October 5, 2025 10:46

google-oss-prow bot removed the do-not-merge/work-in-progress label Oct 5, 2025

google-oss-prow bot requested a review from orfeas-k October 5, 2025 10:46

andyatmiami suggested changes Oct 6, 2025

View reviewed changes

components/crud-web-apps/tensorboards/frontend/package-lock.json Show resolved Hide resolved

.github/workflows/twa_multi_arch_test.yaml Outdated Show resolved Hide resolved

.github/workflows/twa_frontend_tests.yaml Show resolved Hide resolved

google-oss-prow bot assigned andyatmiami Oct 6, 2025

yehudit1987 force-pushed the feat/migrate_twa_tests branch 2 times, most recently from 2615d17 to a97625b Compare October 15, 2025 09:05

google-oss-prow bot added size/XL and removed size/XXL labels Oct 15, 2025

yehudit1987 force-pushed the feat/migrate_twa_tests branch from a97625b to 09f01c5 Compare October 15, 2025 11:05

andyatmiami reviewed Oct 20, 2025

View reviewed changes

google-oss-prow bot added the ok-to-test label Oct 20, 2025

andyatmiami mentioned this pull request Oct 20, 2025

feat: Migrate vwa workflows clean #625

Merged

yehudit1987 force-pushed the feat/migrate_twa_tests branch from 09f01c5 to 979501e Compare October 26, 2025 12:59

andyatmiami approved these changes Oct 27, 2025

View reviewed changes

google-oss-prow bot added the lgtm label Oct 27, 2025

google-oss-prow bot added the approved label Oct 28, 2025

feat: Migrate TWA test-related workflows

bf807b4

Signed-off-by: Yehudit Kerido <[email protected]>

yehudit1987 force-pushed the feat/migrate_twa_tests branch from 979501e to bf807b4 Compare October 28, 2025 16:08

google-oss-prow bot removed the lgtm label Oct 28, 2025

google-oss-prow bot added the lgtm label Oct 28, 2025

google-oss-prow bot merged commit e33dc11 into kubeflow:notebooks-v1 Oct 28, 2025
13 checks passed

github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Oct 28, 2025

feat: Migrate TWA test-related workflows #627

feat: Migrate TWA test-related workflows #627

Conversation

yehudit1987 commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andyatmiami left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andyatmiami left a comment

Choose a reason for hiding this comment

Uh oh!

andyatmiami Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

andyatmiami Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

yehudit1987 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

kimwnasptd Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

yehudit1987 Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

andyatmiami Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

yehudit1987 Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andyatmiami commented Oct 20, 2025

Uh oh!

andyatmiami left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kimwnasptd commented Oct 28, 2025

Uh oh!

google-oss-prow bot commented Oct 28, 2025

Uh oh!

kimwnasptd commented Oct 28, 2025

Uh oh!

andyatmiami commented Oct 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yehudit1987 commented Sep 30, 2025 •

edited

Loading

yehudit1987 Oct 22, 2025 •

edited

Loading

andyatmiami left a comment •

edited

Loading