feat: adopt structlog for structured logging - #642
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
99976ce to
bb76adc
Compare
|
/assign |
lntutor
left a comment
There was a problem hiding this comment.
structlog is imported by the new module and by the updated SDK modules, but this PR does not change pyproject.toml or uv.lock to declare it. In a clean repository environment, uv run python -c "import structlog" currently raises ModuleNotFoundError.
That means importing an affected client after this change will fail for downstream users who install the SDK from its declared dependencies. Please add the runtime dependency to pyproject.toml, regenerate uv.lock, and add a small import/configuration test so the package dependency is covered.
|
@lntutor: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks for the review! I've added the structlog dependency, updated uv.lock, and added a structured logging test. Please take another look. |
There was a problem hiding this comment.
the file has no logging calls
e95cc0e to
1134321
Compare
|
Thanks! I've removed the unused logger from this file. |
|
Thanks @Sumitha007 |
|
hey @Sumitha007 can u resolve the conflicts ? |
Signed-off-by: Sumitha007 <jsumitha012@gmail.com>
Signed-off-by: Sumitha007 <jsumitha012@gmail.com>
Signed-off-by: Sumitha007 <jsumitha012@gmail.com>
Signed-off-by: Sumitha007 <jsumitha012@gmail.com>
1134321 to
c24703f
Compare
|
New changes are detected. LGTM label has been removed. |
What this PR does / why we need it
This PR introduces structured logging support to the Kubeflow SDK using
structlog.Changes
kubeflow.common.structured_loggingmodule.configure_logging()API for configuring structured logging.get_logger()helper for creating structured loggers.logging.getLogger(__name__)withget_logger(__name__)across the SDK modules.configure_logging()is explicitly called.Which issue(s) this PR fixes
Fixes #631
Checklist
ruff formatpassedruff check .passed