Skip to content

fix(trainer): preserve local job runtime metadata - #657

Open
lntutor wants to merge 1 commit into
kubeflow:mainfrom
lntutor:fix/localprocess-runtime-metadata
Open

fix(trainer): preserve local job runtime metadata#657
lntutor wants to merge 1 commit into
kubeflow:mainfrom
lntutor:fix/localprocess-runtime-metadata

Conversation

@lntutor

@lntutor lntutor commented Jul 26, 2026

Copy link
Copy Markdown

Summary:

  • Return each local job's stored runtime from unfiltered listings.
  • Add regression coverage for list_jobs without a runtime filter.

Fixes #653

Validation:

  • make test-python
  • make verify
  • uv run pytest kubeflow/trainer/backends/localprocess/backend_test.py -q

@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign astefanutti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Welcome to the Kubeflow SDK! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
  • Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

Signed-off-by: Loi Nguyen <loinguyen@local>
Signed-off-by: Loi Nguyen <1948922+lntutor@users.noreply.github.com>
@lntutor
lntutor force-pushed the fix/localprocess-runtime-metadata branch from d6e720f to 3f814df Compare July 26, 2026 06:22
@kingabdulsalamsas111-lgtm

Copy link
Copy Markdown
Contributor

Thanks for picking this up! I reported the issue in #653, and it's great to see both the fix and a regression test included. Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LocalProcessBackend.list_jobs() returns incorrect runtime metadata for unfiltered job listings

2 participants