Skip to content

chore(spark): add SparkClient API delegation coverage - #658

Open
lntutor wants to merge 1 commit into
kubeflow:mainfrom
lntutor:test/spark-client-api-coverage
Open

chore(spark): add SparkClient API delegation coverage#658
lntutor wants to merge 1 commit into
kubeflow:mainfrom
lntutor:test/spark-client-api-coverage

Conversation

@lntutor

@lntutor lntutor commented Jul 26, 2026

Copy link
Copy Markdown

Summary

  • add unit coverage for SparkClient.connect() against existing Spark Connect servers, including URL validation and token propagation
  • cover create-mode forwarding of session configuration to the Kubernetes backend
  • cover public session-management delegation, including delete_session() returning None and get_session_logs() forwarding follow by keyword

Part of #609. This is intentionally limited to the Spark API layer; it does not overlap with #610, #614, or #621.

Validation

  • uv run pytest -q kubeflow/spark/api/spark_client_test.py — 15 passed
  • uv run ruff check kubeflow/spark/api/spark_client_test.py
  • uv run ruff format --check kubeflow/spark/api/spark_client_test.py
  • make verify

I also ran make test-python; it entered the unrelated Trainer container-backend test section and did not complete locally, so I stopped that single runner rather than leave it consuming resources. The focused Spark suite is clean and CI will run the repository gate.

@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign electronic-waste for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Welcome to the Kubeflow SDK! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
  • Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

@lntutor
lntutor force-pushed the test/spark-client-api-coverage branch from 4c14d46 to 3c24d48 Compare July 26, 2026 06:26
@lntutor lntutor changed the title test(spark): cover SparkClient API delegation chore(spark): cover SparkClient API delegation Jul 26, 2026
@lntutor lntutor changed the title chore(spark): cover SparkClient API delegation chore(spark): test SparkClient API delegation Jul 27, 2026
@lntutor lntutor changed the title chore(spark): test SparkClient API delegation chore(spark): cover SparkClient API delegation Jul 27, 2026
Signed-off-by: Loi Nguyen <1948922+lntutor@users.noreply.github.com>
@lntutor
lntutor force-pushed the test/spark-client-api-coverage branch from 3c24d48 to f5d9337 Compare July 27, 2026 15:54
@lntutor lntutor changed the title chore(spark): cover SparkClient API delegation test(spark): cover SparkClient API delegation Jul 27, 2026
@lntutor lntutor changed the title test(spark): cover SparkClient API delegation chore(spark): cover SparkClient API delegation Jul 27, 2026
@lntutor lntutor changed the title chore(spark): cover SparkClient API delegation chore(spark): add SparkClient API delegation coverage Jul 30, 2026
@lntutor

lntutor commented Aug 1, 2026

Copy link
Copy Markdown
Author

Current head f5d9337248adb54764fb36d89653696db76d6b9f is mergeable. The earlier failing Check PR Title run has been superseded by later successful runs on this head, so there is no current title-check failure to fix in the branch. The remaining gate appears to be the Kubeflow/Prow approval path: tide is still pending, and the bot notes that after review with lgtm, approval from an approver such as @electronic-waste is needed. If the change looks good, a maintainer/approver can move it forward from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant