Skip to content

fix(spark): normalize non-streaming pod log lines - #660

Open
lntutor wants to merge 1 commit into
kubeflow:mainfrom
lntutor:fix/spark-log-splitting
Open

fix(spark): normalize non-streaming pod log lines#660
lntutor wants to merge 1 commit into
kubeflow:mainfrom
lntutor:fix/spark-log-splitting

Conversation

@lntutor

@lntutor lntutor commented Jul 26, 2026

Copy link
Copy Markdown

Summary

  • normalize non-streaming Kubernetes pod logs with splitlines()
  • avoid synthetic blank entries for empty or newline-terminated responses
  • handle CRLF responses while preserving genuine interior blank lines

Fixes #656

Validation

  • uv run pytest -q kubeflow/spark/backends/kubernetes/utils_test.py
  • make verify
  • git diff --check

@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kramaranya for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Welcome to the Kubeflow SDK! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
  • Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

Signed-off-by: Loi Nguyen <1948922+lntutor@users.noreply.github.com>
@lntutor
lntutor force-pushed the fix/spark-log-splitting branch from d023d81 to e17507c Compare July 26, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spark log retrieval returns an extra empty line for empty or newline-terminated output

1 participant