refactor: move shared job utilities to common module - #667
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
Signed-off-by: Debashich <debashishsinha555@gmail.com>
afafc94 to
37f204d
Compare
|
/cc @tariq-hasan @andreyvelich The PR is ready for review. I’ve implemented KEP-107, added tests for the new shared common utilities, and verified the full test suite ( Please take a look when you’re free. Thanks! |
What this PR does / why we need it
Implements KEP-107 by moving shared job-submission utilities used by the Trainer, Optimizer, and Spark clients into
kubeflow.common.Changes
Adds shared Kubernetes utilities for:
Adds a shared
Eventdataclass tokubeflow.common.types.Refactors Trainer, Optimizer, and Spark backends to use the common utilities.
Re-exports
Eventthrough Trainer types for compatibility.Removes duplicated utility implementations and redundant tests.
Adds unit tests covering shared utilities, timeout handling, and pod log streaming.
This reduces duplication across the three clients and improves long-term maintainability and consistency.
Testing
make test-python— 642 tests passedmake verify— All checks passedWhich issue(s) this PR fixes
Fixes #608
Checklist