fix(trainer): raise RuntimeError for failed TrainJobs - #670
Open
kingabdulsalamsas111-lgtm wants to merge 1 commit into
Open
fix(trainer): raise RuntimeError for failed TrainJobs#670kingabdulsalamsas111-lgtm wants to merge 1 commit into
kingabdulsalamsas111-lgtm wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
What this PR does / why we need it:
This PR updates
LocalProcessBackend.wait_for_job_status()to immediately raise aRuntimeErrorwhen a TrainJob enters theFailedstate, unlessTRAINJOB_FAILEDis explicitly included in the expected status set.Previously,
LocalProcessBackend.wait_for_job_status()continued polling until the timeout even after the TrainJob had already failed. This behavior was inconsistent with the Container and Kubernetes backends, which already raise aRuntimeErroras soon as an unexpected failed status is observed.This change aligns the LocalProcessBackend behavior with the other backends and avoids unnecessary waiting after a job has already failed.
In addition to the implementation change, this PR includes a regression test to verify that
wait_for_job_status()raises aRuntimeErrorimmediately when a TrainJob reaches theFailedstate unexpectedly.Which issue(s) this PR fixes (optional, in
Fixes #<662>format, will close the issue(s) when PR gets merged):Fixes #<Fixes #662>
Checklist:
Testing
python -m pytest kubeflow/trainer/backends/localprocess/backend_test.py
Output:
============================= 28 passed =============================