Skip to content

fix(spark): clean up SparkConnect CR on failure and align states - #676

Open
TensorDevLJ wants to merge 2 commits into
kubeflow:mainfrom
TensorDevLJ:fix/sparkconnect-cleanup-476
Open

fix(spark): clean up SparkConnect CR on failure and align states#676
TensorDevLJ wants to merge 2 commits into
kubeflow:mainfrom
TensorDevLJ:fix/sparkconnect-cleanup-476

Conversation

@TensorDevLJ

Copy link
Copy Markdown

Fixes #476

Summary

  • Best-effort delete SparkConnect CR when wait/connect fails after create
  • Align SparkConnectState with Spark Operator (add New, remove Running)
  • Add unit tests for cleanup failure paths

Notes

State alignment overlaps with #572 / #577; this PR also covers the cleanup gap from #476.

Test plan

  • backend create_and_connect cleanup tests
  • SparkConnectState / utils parse tests
  • ruff check/format on touched files

Delete orphaned SparkConnect resources when wait/connect fails after create, and align SparkConnectState with the Spark Operator model by removing Running and adding New.

Fixes kubeflow#476

Signed-off-by: likj <likj@redhat.com>
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Welcome to the Kubeflow SDK! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
  • Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

Signed-off-by: Likhitha J <143345274+TensorDevLJ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SparkConnect CR cleanup behavior on failure and SDK state mismatch

1 participant