fix(spark): improve port-forward stability for local development - #678
Open
KartikSuryavanshi wants to merge 1 commit into
Open
fix(spark): improve port-forward stability for local development#678KartikSuryavanshi wants to merge 1 commit into
KartikSuryavanshi wants to merge 1 commit into
Conversation
- Reorder port-forward candidates to prefer service over pod (service-based port-forward via kube-proxy is more stable than pod-based via kube-apiserver proxy, especially in Kind clusters) - Add --address 127.0.0.1 to kubectl port-forward to force IPv4-only binding, preventing IPv6 localhost resolution conflicts on WSL and other platforms - Add 2s stabilization delay after port-forward restart to allow TCP port release before reconnecting - Log stderr from dead port-forward process for better diagnostics - Fix test mock to include service_name and add service-first ordering assertion Fixes kubeflow#492 Signed-off-by: Kartik Suryavanshi <158498247+KartikSuryavanshi@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-oss-prow
Bot
requested review from
Electronic-Waste,
andreyvelich and
szaher
July 28, 2026 13:04
Contributor
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #492 - Spark Connect local example fails during SDK-managed port-forward.
The SDK-managed port-forward fails in local/Kind cluster environments because:
Changes:
Reorder port-forward candidates (
backend.py): Prefer service-based port-forward (via kube-proxy, more stable) over pod-based (via kube-apiserver proxy, unstable in Kind clusters). Tryinfo.service_namefirst, then{name}-server, then{name}-svc, with pod as fallback.Add
--address 127.0.0.1(backend.py): Force IPv4-only binding on kubectl port-forward to prevent IPv6 localhost resolution conflicts on WSL and other platforms.Add stabilization delay (
backend.py): Add 2s delay after port-forward restart to allow TCP port release before reconnecting.Log stderr on death (
backend.py): Read and log stderr from dead port-forward process for better diagnostics.Fix test mock (
backend_test.py): Addservice_nameto mock response and add service-first ordering assertion.Validation:
ruff checkandruff formatpass cleanlyFixes #492