feat: [KEP-107] Support options in submit_job() for SparkApplication jobs - #685
feat: [KEP-107] Support options in submit_job() for SparkApplication jobs#685Goku2099 wants to merge 5 commits into
options in submit_job() for SparkApplication jobs#685Conversation
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
tariq-hasan
left a comment
There was a problem hiding this comment.
Hi @Goku2099! Thanks for raising the PR! I have added a few comments.
andreyvelich
left a comment
There was a problem hiding this comment.
Thanks a lot for working on this, @Goku2099! 🙏
This review was performed with the help of AI tools. Please see the inline comments.
| PodTemplateOverride, | ||
| Toleration, | ||
| ) | ||
| from kubeflow.trainer.test.common import FAILED, SUCCESS, TestCase |
There was a problem hiding this comment.
Spark tests shouldn't import trainer test helpers — kubeflow/spark/test/common.py has an identical TestCase (including expected_error) and is what every other spark test uses.
| from kubeflow.trainer.test.common import FAILED, SUCCESS, TestCase | |
| from kubeflow.spark.test.common import FAILED, SUCCESS, TestCase |
There was a problem hiding this comment.
Can we move them to kubeflow.common ?
There was a problem hiding this comment.
@andreyvelich Good point. Since this involves reorganizing shared test utilities across multiple components, I'd prefer to keep it separate from this feature PR. I can open a follow-up issue to move the common test helpers into a shared module and update the imports accordingly.
There was a problem hiding this comment.
@andreyvelich I've created a tracking issue for consolidating the shared test helpers into kubeflow.common: #700 . Since this involves shared infrastructure across multiple SDK components, I'd prefer to keep it separate from this feature PR.
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
cb69ef8 to
dee15a7
Compare
|
@andreyvelich - I removed the pod template override support and simplified the implementation accordingly. I also updated the batch job options example to keep it focused on demonstrating the options API: it now uses a unique job name for idempotent execution and verifies that the configured Name, Labels, Annotations, NodeSelector, and Toleration are applied to the created SparkApplication. |
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
|
Hi @andreyvelich , I've addressed all of the review comments, Could you please take another look when you have a chance? Thanks! |
Summary
This PR adds support for configuring SparkApplication jobs through the
optionsparameter inSparkClient.submit_job().The following SparkApplication configurations are now supported through
options:Additional Changes
options.ref - #520