feat(trainer): add tail_lines support to get_job_logs - #686
Open
Sumitha007 wants to merge 2 commits into
Open
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-oss-prow
Bot
requested review from
Electronic-Waste,
astefanutti and
szaher
July 30, 2026 04:23
Signed-off-by: Sumitha007 <jsumitha012@gmail.com>
Sumitha007
force-pushed
the
feat-log-streaming-tail-support
branch
from
July 30, 2026 04:24
a6274ef to
312145f
Compare
Signed-off-by: Sumitha007 <jsumitha012@gmail.com>
Sumitha007
force-pushed
the
feat-log-streaming-tail-support
branch
from
July 30, 2026 04:26
db594a8 to
d0cf7d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds
tail_linessupport toTrainerClient.get_job_logs()and propagates it through all Trainer backends.Changes
tail_lines: int | None = NonetoTrainerClient.get_job_logs().RuntimeBackendinterface.tail_linesin the Kubernetes backend by forwarding it to the Kubernetes Pod Logs API.tail_linesin the Container backend and Docker/Podman adapters.tail_linesin the LocalProcess backend andLocalJob.logs().tail_linesis not specified.Which issue(s) this PR fixes:
Fixes #682
Checklist: