KEP-2170: Change API Group Name to trainer.kubeflow.org
#2413
Conversation
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
…ference. Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
google-oss-prow
bot
requested review from
deepanker13,
franciscojavierarceo,
helenxie-bit and
Doris-xm
|
@Electronic-Waste: GitHub didn't allow me to request PR reviews from the following users: saileshd1402, varshaprasad96, astefanutti, seanlaii, truc0. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Electronic-Waste <[email protected]>
Electronic-Waste
changed the title
trainer.kubeflow.orgtrainer.kubeflow.org
There was a problem hiding this comment.
Thank you for updating this @Electronic-Waste!
/assign @tenzen-y @astefanutti @kubeflow/wg-training-leads
There was a problem hiding this comment.
I notice that JobSet and Kueue doesn't have host name in the files name:
- https://github.com/kubernetes-sigs/jobset/tree/main/api/jobset/v1alpha2
- https://github.com/kubernetes-sigs/kueue/tree/main/apis/kueue/v1beta1
@tenzen-y @kannon92 @astefanutti @Electronic-Waste @kubeflow/wg-training-leads Do we want to follow similar structure ?
`/pkg/apis/trainer/v1alpha1/...
There was a problem hiding this comment.
I'm OK with it in any form if that structure should work fine with a couple of code generation mechanisms.
There was a problem hiding this comment.
SGTM. It looks more precise.
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
|
@andreyvelich I've updated the dir name from |
|
/rerun-all |
1 similar comment
|
/rerun-all |
|
Thanks @Electronic-Waste! /lgtm |
|
@astefanutti: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Thank you for this @Electronic-Waste!
/lgtm
/assign @tenzen-y
There was a problem hiding this comment.
Overall lgtm
Could you update design as well?
https://github.com/kubeflow/training-operator/tree/master/docs/proposals/2170-kubeflow-training-v2
Signed-off-by: Electronic-Waste <[email protected]>
There was a problem hiding this comment.
Thank you @Electronic-Waste!
/lgtm
/assign @tenzen-y @astefanutti
I've updated it. Please let me know if this PR needs any further fixes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
As we discussed in kubeflow/pipelines#11551 (comment), it's necessary to use different api groups in different components to avoid naming conflicts. So I:
trainer.kubeflow.org/pkg/apis/kubeflow.orgto/pkg/apis/trainer/cc @kubeflow/wg-training-leads @franciscojavierarceo @astefanutti @deepanker13 @saileshd1402 @seanlaii @helenxie-bit @astefanutti @varshaprasad96 @Doris-xm @truc0
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: