-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nominate @Electronic-Waste as a reviewer #2427
Conversation
Signed-off-by: Andrey Velichkevich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM 👍 |
Thanks for your recognition! This is a precious opportunity for me. I will continue contributing to kubeflow in the future! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you!
/hold cancel |
I would like to nominate @Electronic-Waste as a reviewer for Kubeflow Trainer project.
Shao, has done a lot of great contributions to the Kubeflow Trainer V2 project including:
Thanks again for all of you great contributions, Shao, and I am looking forward to continue working with you 🎉
/hold for WG leads review
/assign @kubeflow/wg-training-leads