-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade jobset SDK version to v0.7.3 #2445
Upgrade jobset SDK version to v0.7.3 #2445
Conversation
Signed-off-by: Electronic-Waste <[email protected]>
/cc @kubeflow/wg-training-leads @astefanutti |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @Electronic-Waste!
We should also bump it to v0.8.0 once it is ready since it has DependsOn API support:
kubernetes-sigs/jobset#774
@andreyvelich SGTM.I'll create another issue tracking that. |
I agree with you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will take a little more time |
What this PR does / why we need it:
Since we use jobset v0.7.3 in the manifest:
trainer/manifests/third-party/jobset/kustomization.yaml
Lines 1 to 6 in 0b765d6
We'd better upgrade the jobset SDK version to v0.7.3 as well.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: