Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jobset SDK version to v0.7.3 #2445

Merged

Conversation

Electronic-Waste
Copy link
Member

What this PR does / why we need it:

Since we use jobset v0.7.3 in the manifest:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- https://github.com/kubernetes-sigs/jobset/releases/download/v0.7.3/manifests.yaml

We'd better upgrade the jobset SDK version to v0.7.3 as well.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@Electronic-Waste
Copy link
Member Author

/cc @kubeflow/wg-training-leads @astefanutti

@google-oss-prow google-oss-prow bot requested review from astefanutti and a team February 24, 2025 05:54
Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Electronic-Waste!
We should also bump it to v0.8.0 once it is ready since it has DependsOn API support:
kubernetes-sigs/jobset#774

@Electronic-Waste
Copy link
Member Author

@andreyvelich SGTM.I'll create another issue tracking that.

@tenzen-y
Copy link
Member

@andreyvelich SGTM.I'll create another issue tracking that.

I agree with you

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

Thanks for this @Electronic-Waste! We should also bump it to v0.8.0 once it is ready since it has DependsOn API support: kubernetes-sigs/jobset#774

This will take a little more time

@google-oss-prow google-oss-prow bot merged commit a55f03a into kubeflow:master Feb 24, 2025
14 checks passed
@Electronic-Waste Electronic-Waste deleted the fix/jobset-sdk-version branch February 24, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants