-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] migrate images to ghcr #2455
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: mahdikhashan <[email protected]>
9699402
to
900ca0a
Compare
/cc @kubeflow/wg-automl-leads @Electronic-Waste @varodrig PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating this @mahdikhashan!
Should we do the same for the Training Operator v1.9 ?
@@ -45,7 +46,7 @@ jobs: | |||
id: publish | |||
uses: ./.github/workflows/template-publish-image | |||
with: | |||
image: docker.io/kubeflow/${{ matrix.component-name }} | |||
image: ghcr.io/kubeflow/${{ matrix.component-name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does GHCR support additional paths so we can distinguish images by Kubeflow Project name:
docker pull ghcr.io/kubeflow/trainer/trainer-controller-manager
https://github.com/orgs/kubeflow/packages/container/package/training%2Ftraining-operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this.
Could we check if uploading time does does not exceed 10min?
For example images (mostly releae-1.9 branch), I'm wondering if we take 10 or more time to upload images.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #2446
Checklist: