Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] migrate images to ghcr #2455

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahdikhashan
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2446

Checklist:

  • Docs included if any changes are user facing

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jeffwan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: mahdikhashan <[email protected]>
@mahdikhashan mahdikhashan force-pushed the migrate-images-to-ghcr branch from 9699402 to 900ca0a Compare February 27, 2025 12:18
@mahdikhashan
Copy link
Member Author

/cc @kubeflow/wg-automl-leads @Electronic-Waste @varodrig PTAL!

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this @mahdikhashan!
Should we do the same for the Training Operator v1.9 ?

@@ -45,7 +46,7 @@ jobs:
id: publish
uses: ./.github/workflows/template-publish-image
with:
image: docker.io/kubeflow/${{ matrix.component-name }}
image: ghcr.io/kubeflow/${{ matrix.component-name }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does GHCR support additional paths so we can distinguish images by Kubeflow Project name:

docker pull ghcr.io/kubeflow/trainer/trainer-controller-manager

https://github.com/orgs/kubeflow/packages/container/package/training%2Ftraining-operator

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this.
Could we check if uploading time does does not exceed 10min?

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

For example images (mostly releae-1.9 branch), I'm wondering if we take 10 or more time to upload images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate images in Dockerhub to GHCR
3 participants