Skip to content

Commit

Permalink
Update go test cmd
Browse files Browse the repository at this point in the history
Signed-off-by: Andrey Velichkevich <[email protected]>
  • Loading branch information
andreyvelich committed Feb 6, 2025
1 parent 91bd7ef commit f6dd14b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ endif
# Instructions to run tests.
.PHONY: test
test: ## Run Go unit test.
go test ./pkg/apis/trainer/v1alpha1/... ./pkg/controller/... ./pkg/runtime/... ./pkg/webhooks/... ./pkg/util/... -coverprofile cover.out
go test $(shell go list ./... | grep -v '/test/') -coverprofile cover.out

.PHONY: test-integration
test-integration: envtest jobset-operator-crd scheduler-plugins-crd ## Run Go integration test.
Expand Down
2 changes: 1 addition & 1 deletion cmd/trainer-controller-manager/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import (

kubeflowv1 "github.com/kubeflow/trainer/pkg/apis/trainer/v1alpha1"
kubeflowcontroller "github.com/kubeflow/trainer/pkg/controller"
runtime "github.com/kubeflow/trainer/pkg/runtime"
"github.com/kubeflow/trainer/pkg/runtime"
runtimecore "github.com/kubeflow/trainer/pkg/runtime/core"
"github.com/kubeflow/trainer/pkg/util/cert"
webhooks "github.com/kubeflow/trainer/pkg/webhooks"
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/controller"

runtime "github.com/kubeflow/trainer/pkg/runtime"
"github.com/kubeflow/trainer/pkg/runtime"
)

func SetupControllers(mgr ctrl.Manager, runtimes map[string]runtime.Runtime, options controller.Options) (string, error) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/webhooks/trainingruntime_webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
jobsetv1alpha2 "sigs.k8s.io/jobset/api/jobset/v1alpha2"

kubeflowv1 "github.com/kubeflow/trainer/pkg/apis/trainer/v1alpha1"
runtime "github.com/kubeflow/trainer/pkg/runtime"
"github.com/kubeflow/trainer/pkg/runtime"
)

type TrainingRuntimeWebhook struct {
Expand Down

0 comments on commit f6dd14b

Please sign in to comment.