Missing Jaxjobs in aggregation ClusterRole

[DnPlas]

What happened?

Looks like jaxjobs are missing from the kubeflow-training-roles.yaml because when I tested the ability to create jaxjobs as a Kubeflow Profile in the profile's namespace, I got:

kubectl auth can-i create jaxjobs --as=system:serviceaccount:profile-example:default-editor --namespace=profile-example
no

After adding the jaxjobs in the aforementioned ClusterRole, I get:

kubectl auth can-i create jaxjobs --as=system:serviceaccount:profile-example:default-editor --namespace=profile-example
yes

What did you expect to happen?

The Kubeflow profiles to have permissions to:

• create
• delete
• get
• list
• patch
• update
• watch
  JaxJobs

Environment

Kubernetes version:

Client Version: v1.31.5
Kustomize Version: v5.4.2
Server Version: v1.29.13
WARNING: version difference between client (1.31) and server (1.29) exceeds the supported minor version skew of +/-1

Training Operator version:

$ kubectl get pods -n kubeflow -l control-plane=kubeflow-training-operator -o jsonpath="{.items[*].spec.containers[*].image}"

kubeflow/training-operator:v1-5170a

Impacted by this bug?

Give it a 👍 We prioritize the issues with most 👍

[andreyvelich]

Thank you for creating this @DnPlas, great catch! Yes, we should update the RBAC.

@DnPlas @sandipanpanda Please can you create the hot fix at release-1.9 branch to add the required permissions ?
https://github.com/kubeflow/training-operator/blob/release-1.9/manifests/overlays/kubeflow/kubeflow-training-roles.yaml

[andreyvelich]

/remove-label lifecycle/needs-triage

[andreyvelich]

/good-first-issue

[google-oss-prow]

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[DnPlas]

#2417 sent!

[DnPlas]

Fixed in #2417