Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds jaxjobs to the kubeflow-training-roles.yaml ClusterRole #2417

Merged

Conversation

DnPlas
Copy link

@DnPlas DnPlas commented Feb 5, 2025

This commit adds jaxjobs to the aggregation ClusterRole for Kubeflow, which allows Kubeflow Profiles to have edit and admin rights over this CR.

Fixes #2416

Checklist:

  • Docs included if any changes are user facing

This commit adds jaxjobs to the aggregation ClusterRole for Kubeflow,
which allows Kubeflow Profiles to have edit and admin rights over this CR.

Fixes kubeflow#2416

Signed-off-by: Daniela Plascencia <[email protected]>
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Feb 5, 2025

Pull Request Test Coverage Report for Build 13156740096

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12989971818: 0.0%
Covered Lines: 85
Relevant Lines: 85

💛 - Coveralls

@google-oss-prow google-oss-prow bot merged commit 778cd72 into kubeflow:release-1.9 Feb 5, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants