Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename paddlepaddle_defaults.go file name #2399

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

ChristianZaccaria
Copy link
Contributor

What this PR does / why we need it:
Renaming file from paddlepaddle_defautls.go to paddlepaddle_defaults.go

Checklist:

  • Docs included if any changes are user facing

Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test
/rerun-all

@Electronic-Waste
Copy link
Member

/rerun-all
/cc @kubeflow/wg-training-leads @astefanutti @helenxie-bit

@google-oss-prow google-oss-prow bot requested review from a team and helenxie-bit January 22, 2025 12:00
Copy link

@Electronic-Waste: GitHub didn't allow me to request PR reviews from the following users: astefanutti.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/rerun-all
/cc @kubeflow/wg-training-leads @astefanutti @helenxie-bit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Electronic-Waste, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12906776123

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12862208924: 0.0%
Covered Lines: 85
Relevant Lines: 85

💛 - Coveralls

@google-oss-prow google-oss-prow bot merged commit 6eeb1fb into kubeflow:master Jan 22, 2025
56 checks passed
@andreyvelich
Copy link
Member

/cherry-pick release-1.9

@google-oss-robot
Copy link

@andreyvelich: new pull request created: #2400

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants