Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominate @Electronic-Waste as a reviewer #2427

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

andreyvelich
Copy link
Member

I would like to nominate @Electronic-Waste as a reviewer for Kubeflow Trainer project.

Shao, has done a lot of great contributions to the Kubeflow Trainer V2 project including:

Thanks again for all of you great contributions, Shao, and I am looking forward to continue working with you 🎉

/hold for WG leads review
/assign @kubeflow/wg-training-leads

Signed-off-by: Andrey Velichkevich <[email protected]>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

LGTM 👍
/lgtm

@Electronic-Waste
Copy link
Member

Thanks for your recognition! This is a precious opportunity for me. I will continue contributing to kubeflow in the future!

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you!

@andreyvelich
Copy link
Member Author

/hold cancel

@google-oss-prow google-oss-prow bot merged commit ab98a5a into kubeflow:master Feb 7, 2025
14 checks passed
@andreyvelich andreyvelich deleted the update-reviewers branch February 7, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants