Skip to content

KKP: CIS 1.23 Benchmark #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2025
Merged

KKP: CIS 1.23 Benchmark #1988

merged 3 commits into from
Sep 23, 2025
+1,665 −1,096

Conversation

ahmedwaleedmalik
Copy link
Member

No description provided.

@ahmedwaleedmalik
KKP: CIS 1.23 Benchmark
c261c59 
Signed-off-by: Waleed Malik <[email protected]>
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 22, 2025
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 22, 2025
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 23, 2025
@ahmedwaleedmalik
Add CIS benchmark to 2.28
720ad43 
Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review September 23, 2025 08:23
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2025
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Sep 23, 2025
Open
kron4eg
kron4eg approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 29db3214c1663cb6345519b69029b8784622ca42

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2025
@kubermatic-bot kubermatic-bot merged commit 47837cf into kubermatic:main Sep 23, 2025
11 checks passed
@ahmedwaleedmalik
Copy link
Member Author

/hold

cc @csengerszabo

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2025
@ahmedwaleedmalik
Copy link
Member Author

Too late, anyways if you have any concerns regarding this @csengerszabo do let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedwaleedmalik @kubermatic-bot @kron4eg