Skip to content

Conversation

@hirishh
Copy link
Contributor

@hirishh hirishh commented Nov 26, 2025

Hello,

This PR allows the use of queryParameters in the Generic_list and Generic_listNamespaced api.
This is particularly useful for example to add "labelSelector" parameter.

I deal with a 5k nodes cluster, I need to save some bandwidth :)

Best,

hirishh

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hirishh
Once this PR has been reviewed and has the lgtm label, please assign ityuhui for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from ityuhui November 26, 2025 16:32
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 26, 2025
@brendandburns
Copy link
Contributor

This looks good to me, but it is a breaking change, can we add this function as a new signature instead of breaking the existing signature?

@hirishh
Copy link
Contributor Author

hirishh commented Nov 26, 2025

Yes sure, do you have a proposal for the naming? Generic_list_qp and Generic_listNamespaced_qp?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants