feat: add target group info metric #3581

msvticket · 2024-02-16T16:26:20Z

Description

When monitoring target groups by importing cloudwatch metrics it's tricky to see what service an alert corresponds to. This PR adds a relation metric called aws_target_group_info that you can use to enrich the metric from cloudwatch with labels for service and namespace.

Example PromQL:

aws_target_group_info * on(target_group) group_left last_over_time(aws_applicationelb_healthy_host_count_minimum[20m])

Checklist

Added tests that cover your change (if possible)
Added/modified documentation as required (such as the README.md, or the docs directory)
Manually tested
Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Backfilled missing tests for code in same general area 🎉
Refactored something and made the world a better place 🌟

k8s-ci-robot · 2024-02-16T16:26:30Z

Hi @msvticket. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

oliviassss · 2024-03-13T18:12:31Z

/ok-to-test

msvticket · 2024-05-08T08:25:12Z

Could you please review as well @oliviassss ?

controllers/ingress/group_controller.go

oliviassss · 2024-05-21T21:46:44Z

main.go

@@ -114,11 +116,15 @@ func main() {
 		cloud.VpcID(), cloud.EC2(), mgr.GetClient(), controllerCFG.DefaultTags, ctrl.Log.WithName("backend-sg-provider"))
 	sgResolver := networking.NewDefaultSecurityGroupResolver(cloud.EC2(), cloud.VpcID())
 	elbv2TaggingManager := elbv2deploy.NewDefaultTaggingManager(cloud.ELBV2(), cloud.VpcID(), controllerCFG.FeatureGates, cloud.RGT(), ctrl.Log)
+	targetGroupMetric, err := metrics.RegisterTargetGroupInfoMetric(k8smetric.Registry)
+	if err != nil {
+		setupLog.Error(err, "failed to register target binding information metric")


nit: should it be target group instead of target binding?

Well, that depends if look at it from the AWS or k8s perspectives. The k8s resource created by alb controller for a AWS target group is a targetgroupbinding. So either would be correct...

oliviassss · 2024-05-21T21:48:52Z

pkg/aws/metrics/target_group.go

+)
+
+const (
+	metricTargetGroupBinding = "target_group_info"


nit: metricTargetGroup maybe more precise?

pkg/aws/metrics/target_group.go

oliviassss · 2024-05-21T21:53:04Z

@msvticket, sorry for the delay, and thanks for the contribution to improve the observability for LBC!
I left some nit comments. Also, can you please adding the unit test coverage for pkg/aws/metrics/target_group.go?

oliviassss · 2024-05-21T21:53:25Z

want some second opnions from @M00nF1sh
/assign @M00nF1sh

controllers/ingress/group_controller.go

k8s-ci-robot · 2024-05-27T13:32:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: msvticket
Once this PR has been reviewed and has the lgtm label, please ask for approval from m00nf1sh. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-triage-robot · 2024-08-25T18:29:34Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

msvticket · 2024-09-02T07:52:20Z

/remove-lifecycle stale

k8s-ci-robot · 2024-09-24T05:51:55Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-triage-robot · 2024-12-23T05:56:01Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-01-22T06:27:11Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

msvticket · 2025-01-22T07:46:07Z

/remove-lifecycle rotten

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2024

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 16, 2024

k8s-ci-robot requested review from M00nF1sh and oliviassss February 16, 2024 16:26

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024

oliviassss reviewed May 21, 2024

View reviewed changes

k8s-ci-robot assigned M00nF1sh May 21, 2024

msvticket commented May 27, 2024

View reviewed changes

controllers/ingress/group_controller.go Show resolved Hide resolved

feat: target group info metric

c0b3267

msvticket force-pushed the targetgroupmetric branch from 47fce56 to c0b3267 Compare May 27, 2024 13:32

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 23, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2025

k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 22, 2025

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add target group info metric #3581

feat: add target group info metric #3581

msvticket commented Feb 16, 2024 •

edited

Loading

k8s-ci-robot commented Feb 16, 2024

oliviassss commented Mar 13, 2024

msvticket commented May 8, 2024

oliviassss May 21, 2024

msvticket May 27, 2024

oliviassss May 21, 2024

msvticket May 27, 2024

oliviassss commented May 21, 2024

oliviassss commented May 21, 2024

k8s-ci-robot commented May 27, 2024

k8s-triage-robot commented Aug 25, 2024

msvticket commented Sep 2, 2024

k8s-ci-robot commented Sep 24, 2024

k8s-triage-robot commented Dec 23, 2024

k8s-triage-robot commented Jan 22, 2025

msvticket commented Jan 22, 2025

feat: add target group info metric #3581

Are you sure you want to change the base?

feat: add target group info metric #3581

Conversation

msvticket commented Feb 16, 2024 • edited Loading

Description

Checklist

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

k8s-ci-robot commented Feb 16, 2024

oliviassss commented Mar 13, 2024

msvticket commented May 8, 2024

oliviassss May 21, 2024

Choose a reason for hiding this comment

msvticket May 27, 2024

Choose a reason for hiding this comment

oliviassss May 21, 2024

Choose a reason for hiding this comment

msvticket May 27, 2024

Choose a reason for hiding this comment

oliviassss commented May 21, 2024

oliviassss commented May 21, 2024

k8s-ci-robot commented May 27, 2024

k8s-triage-robot commented Aug 25, 2024

msvticket commented Sep 2, 2024

k8s-ci-robot commented Sep 24, 2024

k8s-triage-robot commented Dec 23, 2024

k8s-triage-robot commented Jan 22, 2025

msvticket commented Jan 22, 2025

msvticket commented Feb 16, 2024 •

edited

Loading