Added check to validate IPv6Address changes

[parambath92]

Issue

Fixes bug #3743

Description

Added one more check validating if currentIPAddressType is updated the same as desiredIPAddressType (defined in the service configuration) when the IP Address Type is changed to dualstack mode with the IPv6 addresses defined in the dualstack mode.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

Welcome @parambath92!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @parambath92. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: parambath92
Once this PR has been reviewed and has the lgtm label, please assign kishorj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[parambath92]

Hi @kishorj @wweiwei-li , Can you please review this change ?

[shraddhabang]

/ok-to-test

[parambath92]

Hi @shraddhabang , looks like the tests went through. Can you please review ?

[wweiwei-li]

Hey, I believe we need to check whether IPv6Address is updated rather than IPAddressType. Also, While checking IPv6Address, make sure it won't impact ingress behavior as I think the ALB does not support assign static ip. resLB.Spec.Type != elbv2model.LoadBalancerTypeApplication

[witalisoft]

@parambath92 any updates ?

[parambath92]

Hi @witalisoft ,
Apologies for the delay. I will address the review comments and make the changes.

[parambath92]

Hi @wweiwei-li , Can you please review if this change is fine ?

[witalisoft]

@parambath92 any updates ?

[parambath92]

Hi @wweiwei-li , Looks like the job failed in the run. Can you please take a look at it and let me know ?

[wweiwei-li]

Sorry for the late reply. I will review it today

[wweiwei-li]

	desiredSubnets := sets.NewString()
	desiredIPv6Addresses := sets.NewString()
	for _, mapping := range resLB.Spec.SubnetMappings {
		desiredSubnets.Insert(mapping.SubnetID)
		desiredIPv6Addresses.Insert(awssdk.StringValue(mapping.IPv6Address))
	}

	currentSubnets := sets.NewString()
	currentIPv6Addresses := sets.NewString()
	for _, az := range sdkLB.LoadBalancer.AvailabilityZones {
		currentSubnets.Insert(awssdk.StringValue(az.SubnetId))
		if az.LoadBalancerAddresses != nil && len(az.LoadBalancerAddresses) > 0 && az.LoadBalancerAddresses[0].IPv6Address != nil {
			currentIPv6Addresses.Insert(awssdk.StringValue(az.LoadBalancerAddresses[0].IPv6Address))
		}
	}

	isIpv6AddressesEqual := desiredIPv6Addresses.Equal(currentIPv6Addresses)

	if desiredSubnets.Equal(currentSubnets) && isIpv6AddressesEqual {
		return nil
	}

@parambath92 Have you tried building your code ? I think your code has some issues. I was thing something like the above. Can you take a look ?

[witalisoft]

@parambath92 any updates ?

[parambath92]

Hi @wweiwei-li , I have made the changes. Can you please review the PR ?
The PR build failed but the error doesn't show the exact reason.

[wweiwei-li]

/ok-to-test

[wweiwei-li]

currentSubnets.Insert(awssdk.ToString(az.SubnetId)) duplicate line.

[wweiwei-li]

Thinking further, we may also want to check if the AllocatedID, PrivateIPv4Address is changed before updating subnet mapping. Free feel to decide if you want to add it to this PR.

[wweiwei-li]

Hey, There may be more consideration needed than expected. I would like to take a closer look and take over this fix.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale