Skip to content

Add wafv2AclArn field to IngressClassParams #3961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2025
Merged

Add wafv2AclArn field to IngressClassParams #3961

merged 2 commits into from
Aug 13, 2025

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Nov 28, 2024 •
edited
Loading

Issue

part of #2311

Description

Add wafv2AclArn field to IngressClassParams.

  • The field is optional.
  • When the field is absent or empty, the controller behave as same as wafv2-acl-arn annotation.
  • When different arns are set between params and annotations, the error occurs as same as when different arns are set between multiple annotations.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mikutas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2024
@mikutas mikutas changed the title Add WAFv2ACLArn field to IngressClassParams Add wafv2AclArn field to IngressClassParams Nov 28, 2024
@mikutas mikutas marked this pull request as ready for review November 29, 2024 03:13
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2024
@mikutas mikutas force-pushed the wafv2-acl-arn-params branch from 50d613a to a64780e Compare December 7, 2024 09:37
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2024
@zac-nixon zac-nixon removed the request for review from kishorj January 24, 2025 19:51
@zac-nixon
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 24, 2025
@zac-nixon
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2025
@mikutas mikutas force-pushed the wafv2-acl-arn-params branch from a64780e to 56a8dd6 Compare April 25, 2025 03:40
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 25, 2025
@mikutas
Copy link
Contributor Author

mikutas commented Apr 25, 2025

rebased

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2025
@mikutas mikutas force-pushed the wafv2-acl-arn-params branch from 56a8dd6 to 9ccb9af Compare May 1, 2025 09:05
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 1, 2025
@mikutas mikutas force-pushed the wafv2-acl-arn-params branch from 9ccb9af to a2fbb06 Compare May 2, 2025 01:19
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 2, 2025
@mikutas mikutas force-pushed the wafv2-acl-arn-params branch from a2fbb06 to 9cce7f2 Compare May 2, 2025 12:05
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2025
@mikutas mikutas force-pushed the wafv2-acl-arn-params branch from 9cce7f2 to 0ca2e1d Compare May 27, 2025 07:54
@mikutas

This comment was marked as outdated.

Sign in to view
@1ms-ms
Copy link
Contributor

1ms-ms commented Aug 5, 2025

@zac-nixon maybe it would be a good idea to release this together with #4290 as this PR has been stale for a few months

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2025
@mikutas mikutas force-pushed the wafv2-acl-arn-params branch from 0ca2e1d to a13f807 Compare August 8, 2025 01:05
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2025
@mikutas
Copy link
Contributor Author

mikutas commented Aug 8, 2025

resolved conflicts

zac-nixon
zac-nixon approved these changes Aug 8, 2025
View reviewed changes
Copy link
Collaborator

@zac-nixon zac-nixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikutas, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2025
@zac-nixon
Copy link
Collaborator

Thanks for the contribution!

@zac-nixon zac-nixon merged commit f4f5387 into kubernetes-sigs:main Aug 13, 2025
7 of 9 checks passed
@zac-nixon
Copy link
Collaborator

Huh, not sure why the bot didn't merge this a while ago. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zac-nixon zac-nixon zac-nixon approved these changes

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@zac-nixon zac-nixon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikutas @k8s-ci-robot @zac-nixon @1ms-ms